Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After update to v0.1.1 Doorbell shows as accessory not supported #18

Closed
javierireyes opened this issue Jun 10, 2021 · 27 comments · Fixed by #26
Closed

After update to v0.1.1 Doorbell shows as accessory not supported #18

javierireyes opened this issue Jun 10, 2021 · 27 comments · Fixed by #26

Comments

@javierireyes
Copy link

IMG_1017CAD5BEEC-1

@javierireyes javierireyes changed the title After latest update Doorbell shows as accessory not supported After update to v0.1.1 Doorbell shows as accessory not supported Jun 10, 2021
@schliemann
Copy link
Collaborator

It shows as supported in my homekit. Can you try and provide your log?

8BC6A9FB-C7D4-43E9-88FD-11FA5F9D7C23
77959EEF-05F5-426E-BA90-06A29CDAC837

@lenoxys
Copy link
Collaborator

lenoxys commented Jun 11, 2021

Yeah I confirm from the last update the doorbell is shown as not supported but if you ring you will receive a notification.

We have to make a choice between motion sensor or receive ringing events.

@PeterAlexander75
Copy link

Personally, ring events and video would be more important to me.

@andyrooo82
Copy link

Personally, ring events and video would be more important to me.

+1

@schliemann
Copy link
Collaborator

schliemann commented Jun 11, 2021

As I read the ring homebridge plugin (https://github.com/dgreif/ring/tree/master/homebridge#homebridge-ring) it adds the doorbell as a camera accessory, so it has motion and batteryservice and then has a doorbell programmable switch accessory.

@andyrooo82
Copy link

As I read the ring homebridge plugin (https://github.com/dgreif/ring/tree/master/homebridge#homebridge-ring) it adds the doorbell as a camera accessory, so it has motion and batteryservice and then has a doorbell programmable switch accessory.

@schliemann I might be misunderstanding this so apologies in advance but what @PeterAlexander75 and myself mean by ring events is doorbell presses, not ring as in Ring cameras.

@schliemann
Copy link
Collaborator

schliemann commented Jun 11, 2021

I am aware. I am just linking to a plugin that solved this issue.

@andyrooo82
Copy link

I am aware. I am just linking to a plugin that solved this issue.

ah I see - thanks

@lenoxys
Copy link
Collaborator

lenoxys commented Jun 11, 2021

I've pushed a new implementation of DoorBell. But it's still noisy in term of debug.

@PeterAlexander75
Copy link

Although it's not taking homebridge down, I am getting repeated logs showing:-

[6/11/2021, 8:53:43 PM] [homebridge-eufy-security] This plugin generated a warning from the characteristic 'Motion Detected': characteristic was supplied illegal value: null! Home App will reject null for Apple defined characteristics. See https://git.io/JtMGR for more info.

@lenoxys
Copy link
Collaborator

lenoxys commented Jun 11, 2021

Yeah ! saw it forget to update the code for camera device should be good now.

@RamLikeTheTruck
Copy link

Updated and redeployed, Still seeing "This accessory is not currently supported by the Home app."

Wired only Doorbell 2k - T8200 - Log and image of error attached.

I got this error on homebridge boot

[EufySecurity] Restoring existing accessory from cache: Doorbell
(node:15630) UnhandledPromiseRejectionWarning: TypeError: this.eufyDevice.hasBattery is not a function
    at new SecurityDoorbellCameraAccessory (/usr/local/lib/node_modules/homebridge-eufy-security/src/securityDoorbellCameraAccessory.ts:59:24)
    at EufySecurityPlatform.register_accessory (/usr/local/lib/node_modules/homebridge-eufy-security/src/platform.ts:290:9)
    at EufySecurityPlatform.discoverDevices (/usr/local/lib/node_modules/homebridge-eufy-security/src/platform.ts:191:18)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at HomebridgeAPI.<anonymous> (/usr/local/lib/node_modules/homebridge-eufy-security/src/platform.ts:108:7)
(Use `node --trace-warnings ...` to show where the warning was created)
(node:15630) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:15630) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

IMG_0038

@andyrooo82
Copy link

I've updated to v0.1.3 but I'm not seeing a doorbell. I just have the Homebase and a motion sensor. Is this as expected?

@lenoxys
Copy link
Collaborator

lenoxys commented Jun 12, 2021

It doesn't appear as dummy object but if you press the button you will receive a notification from apple home app.

@lenoxys
Copy link
Collaborator

lenoxys commented Jun 12, 2021

Updated and redeployed, Still seeing "This accessory is not currently supported by the Home app."

Wired only Doorbell 2k - T8200 - Log and image of error attached.

I got this error on homebridge boot

[EufySecurity] Restoring existing accessory from cache: Doorbell
(node:15630) UnhandledPromiseRejectionWarning: TypeError: this.eufyDevice.hasBattery is not a function
    at new SecurityDoorbellCameraAccessory (/usr/local/lib/node_modules/homebridge-eufy-security/src/securityDoorbellCameraAccessory.ts:59:24)
    at EufySecurityPlatform.register_accessory (/usr/local/lib/node_modules/homebridge-eufy-security/src/platform.ts:290:9)
    at EufySecurityPlatform.discoverDevices (/usr/local/lib/node_modules/homebridge-eufy-security/src/platform.ts:191:18)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at HomebridgeAPI.<anonymous> (/usr/local/lib/node_modules/homebridge-eufy-security/src/platform.ts:108:7)
(Use `node --trace-warnings ...` to show where the warning was created)
(node:15630) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:15630) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

IMG_0038

It should work the function has battery is herited from device class. it check if the device has battery if not we don't published any battery notification. Are you sure you are using the latest version of the plugin ?

I've added more context on debug for the next version. It would be more easy for us to troubleshoot

@samemory
Copy link
Owner

Hi guys, I have attempted to implement live streaming on the doorbell and maybe remove some of the problems. However, I cannot test it. Can someone try deploying it and see if it works? It's in a separate branch and not published to NPM.
https://github.com/samemory/homebridge-eufy-security/tree/doorbell

@lenoxys
Copy link
Collaborator

lenoxys commented Jun 12, 2021

Hi guys, I have attempted to implement live streaming on the doorbell and maybe remove some of the problems. However, I cannot test it. Can someone try deploying it and see if it works? It's in a separate branch and not published to NPM.
https://github.com/samemory/homebridge-eufy-security/tree/doorbell

Missing one file
src/ffmpeg.ts:4:45 - error TS2307: Cannot find module './new-streaming-delegate' or its corresponding type declarations.

4 import { EufyCameraStreamingDelegate } from './new-streaming-delegate';
~~~~~~~~~~~~~~~~~~~~~~~~~~

@lenoxys
Copy link
Collaborator

lenoxys commented Jun 12, 2021

Hum not working for me :
[6/12/2021, 5:45:42 PM] [EufySecurity] An error occurred while making snapshot request: Error: spawn ffmpeg ENOENT Porte d’entrée [Porte d’entrée ] Snapshot request handler provided empty image buffer! {"name":"eufyLog","hostname":"test","pid":31587,"level":30,"msg":"Livestream of camera T8210P00204622DA started","time":"2021-06-12T15:45:48.946Z","v":0} [6/12/2021, 5:45:48 PM] [EufySecurity] Starting video stream: 1280 x 720, 30 fps, 299 kbps Porte d’entrée [6/12/2021, 5:45:48 PM] [EufySecurity] Failed to start stream: spawn ffmpeg ENOENT Porte d’entrée [6/12/2021, 5:45:48 PM] [EufySecurity] Stopped video stream. Porte d’entrée {"name":"eufyLog","hostname":"test","pid":31587,"level":30,"msg":"Livestream of camera T8210P00204622DA stopped","time":"2021-06-12T15:45:49.127Z","v":0} {"name":"eufyLog","hostname":"test","pid":31587,"level":30,"msg":"Push notification connection successfully established","time":"2021-06-12T15:45:49.159Z","v":0} [6/12/2021, 5:45:51 PM] [EufySecurity] An error occurred while making snapshot request: Error: spawn ffmpeg ENOENT Porte d’entrée [Porte d’entrée ] Snapshot request handler provided empty image buffer!

@samemory
Copy link
Owner

Oops my bad, fixed both of those typos. Had the wrong file name and for the snapshot request, didn't call the function correctly. Try again now with the latest commit.

@lenoxys
Copy link
Collaborator

lenoxys commented Jun 12, 2021

[6/12/2021, 7:24:15 PM] [EufySecurity] An error occurred while making snapshot request: Error: spawn ffmpeg ENOENT Porte d’entrée [Porte d’entrée ] Snapshot request handler provided empty image buffer! [6/12/2021, 7:24:15 PM] [EufySecurity] Porte d’entrée Triggered GET MotionDetected [6/12/2021, 7:24:15 PM] [EufySecurity] Porte d’entrée Handle Motion Sensor: -- false {"name":"eufyLog","hostname":"test","pid":773,"level":30,"msg":"Livestream of camera T8210P00204622DA started","time":"2021-06-12T17:24:19.934Z","v":0} [6/12/2021, 7:24:19 PM] [EufySecurity] Starting video stream: 1280 x 720, 30 fps, 299 kbps Porte d’entrée [6/12/2021, 7:24:19 PM] [EufySecurity] Failed to start stream: spawn ffmpeg ENOENT Porte d’entrée [6/12/2021, 7:24:19 PM] [EufySecurity] Stopped video stream. Porte d’entrée {"name":"eufyLog","hostname":"test","pid":773,"level":30,"msg":"Livestream of camera T8210P00204622DA stopped","time":"2021-06-12T17:24:20.084Z","v":0}

no thumbnail and no stream

@PeterAlexander75
Copy link

I know this is a dumb question, but my experience is you should always ask them, but you do have ffmpeg installed?

@schliemann
Copy link
Collaborator

schliemann commented Jun 12, 2021

Not a dumb question. I might be able to test later tonight.

@lenoxys
Copy link
Collaborator

lenoxys commented Jun 12, 2021

Not a dumb question at all ! I was on my test platform and didn't installed ffmpeg !!! mea culpa ! It's working !

@schliemann
Copy link
Collaborator

Awesome

@samemory
Copy link
Owner

Nice!! Yeah forgot to mention you would need to install that. If this is working, I'll merge the branch into master and update NPM.

@javierireyes
Copy link
Author

Should we use the Homebridge Camera FFmpeg plug-in or the native ffmpeg?

@samemory
Copy link
Owner

@javierireyes I think the homebridge one but either probably would work.

lenoxys added a commit that referenced this issue Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants