[2019.2] Fixing unit.test_loader.LoaderGlobalsTest.test_states test #53224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waynew
approved these changes
May 23, 2019
DmitryKuzmenko
suggested changes
May 23, 2019
DmitryKuzmenko
approved these changes
May 23, 2019
s0undt3ch
approved these changes
May 23, 2019
|
|
||
| # get the names of the globals you should have | ||
| func_name = inspect.stack()[1][3] | ||
| names = next(six.itervalues(salt.utils.yaml.safe_load(getattr(self, func_name).__doc__))) | ||
|
|
||
| # Now, test each module! | ||
| for item in global_vars: | ||
| for item in six.itervalues(global_vars): | ||
| for name in names: | ||
| self.assertIn(name, list(item.keys())) |
There was a problem hiding this comment.
self.assertIn(name, list(item))Or even
self.assertIn(name, item)Less intermediary objects...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixing unit.test_loader.LoaderGlobalsTest.test_states test
What issues does this PR fix or reference?
#53014
Previous Behavior
Test fails.
New Behavior
Test succeeds.
Tests written?
No. Fixing existing test.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.