Update test_schema to mirror the new ValidationErrors in 3.0.0 #52588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bring the Nox changes from 2017.7.9 to 2017.7
Let's not double it.
Conflicts: * requirements/static/centos-6.txt * requirements/static/centos-7.txt * requirements/static/debian-8.txt * requirements/static/debian-9.txt * requirements/static/fedora-28.txt * requirements/static/fedora-29.txt * requirements/static/opensuse-42.txt * requirements/static/opensuse-leap-15.txt * requirements/static/ubuntu-14.04.txt * requirements/static/ubuntu-16.04.txt * requirements/static/ubuntu-18.04.txt
…ate-author Update my contact details, as the previous email address is no longer in use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the failing tests:
unit.utils.test_schemaIn jsonschema version 3.0.0 the validation errors were updated to grab the best match, instead of the default
is not valid under any of the given schemasin this commit: python-jsonschema/jsonschema@17fb9cbto fix this issue: python-jsonschema/jsonschema#498
This updates the tests to check for the error's with more detail when testing with >= 3.0.0
What issues does this PR fix or reference?
Fixes #52085
Tests written?
No- Fixes current tests failing on osx
Commits signed with GPG?
Yes