Initial support for running tests on AIX #52568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s0undt3ch
approved these changes
Apr 17, 2019
Ch3LL
approved these changes
Apr 17, 2019
garethgreenaway
added a commit
to garethgreenaway/salt
that referenced
this pull request
Sep 19, 2019
dwoz
added a commit
that referenced
this pull request
Dec 17, 2019
[master] Porting #52568 to master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for running tests on AIX
What issues does this PR fix or reference?
None, desire to get tests/runtests.py working on AIX to allow for ssh testing
Previous Behavior
python tests/runtests.py would fail due to inability to open a port on the localhost
New Behavior
tests/runtests.py can now run tests on AIX.
Note UTF-8 has to be installed on the AIX system, for example:
installp -acXYg -d /stage/middleware/AIX/bos/bos.loc.utf.EN_US.7.1.0.0.I all
and /etc/environment updated with LC_ALL=EN_US and the machine rebooted
Tests written?
No, now able to run python tests/runtests.py --help and other unit tests
python test/runtests.py -v -n unit/client/test_ssh.py
Commits signed with GPG?
No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.