Virt purge fix #52548
Merged
Virt purge fix #52548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 29a44ac)
|
@rallytime @dwoz this PR is ready for review. |
dwoz
approved these changes
Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes
Exception: unsupported flags (0x4) in function libxlDomainUndefineFlagsthrown when runningvirt.purgeon non-QEMU hypervisor.What issues does this PR fix or reference?
Fixes issue #52547
Previous Behavior
Running
virt.purge test-vmon a Xen hypervisor raised an exception due to unhandled flagNew Behavior
Running
virt.purge test-vmon a Xen hypervisor just worksTests written?
No: catching up such errors would require integration tests with real libvirt on various hypervisors.
Commits signed with GPG?
Yes