Update CodeClimate settings #52485
Merged
Update CodeClimate settings #52485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twangboy
approved these changes
Apr 17, 2019
https://codeclimate.com/github/saltstack/salt/pull/51461 had a matching block with mass of 38. Apparently that's too low because that code was not even the same at all. Bumping it up a bit to avoid false positives. Also disable argument count checks because we really don't need that here.
waynew
force-pushed
the
codeclimate-changes
branch
from
c3b1a60 to
4d9c49b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm pretty sure this is the right place to merge this to - it should go to 2019.2 and develop as well.
This tweaks the settings for code climate.
https://codeclimate.com/github/saltstack/salt/pull/51461 had a matching
block with mass of 38. Apparently that's too low because that code was
not even the same at all. Bumping it up a bit to avoid false positives.
Also disable argument count checks.