Update a couple test modules to use with_tempdir/with_tempfile decorators #50692
+108
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cachedout
approved these changes
Nov 30, 2018
s0undt3ch
suggested changes
Dec 2, 2018
This keeps us from needing to manually clean them up in the tearDown
terminalmage
force-pushed
the
update-tests
branch
from
bb69ff0 to
be14517
Compare
s0undt3ch
approved these changes
Dec 3, 2018
cachedout
approved these changes
Dec 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These prevent us from needing to do manual tempfile cleanup.