Clean up documentation/language in service state. (Fixes #40819) #49940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rallytime Thanks for the ping on this one! Is there any chance you could verify that the current mod_watch description is adequate (you approved, but I changed it and want to be certain)? I feel like a cleaner requisites document might help the clarity of this note. @shallot Any thoughts on these changes? |
|
@MTecknology It looks good to me, but maybe @gtmanfred has some suggestions/comments. |
gtmanfred
approved these changes
Oct 9, 2018
cachedout
approved these changes
Oct 9, 2018
|
@rallytime I think we could safely backport this and it might be helpful to get this into the current supported branches. |
|
Thanks for the reviews! |
rallytime
added
the
bugfix-bckport
rallytime
added
ZZZ[Done]-back-ported-bf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Cleans up some potentially confusing documentation.
What issues does this PR fix or reference?
Commits signed with GPG?
Yes
Disclaimer: I had a hard time coming up with a simple way to describe mod_watch. Once reviewed, I would like to update the documentation for other mod_watch functions.