Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve management of interfaces in debian-based distributions #49355

Merged
merged 14 commits into from
Aug 30, 2018
Merged

Improve management of interfaces in debian-based distributions #49355

merged 14 commits into from
Aug 30, 2018

Conversation

MTecknology
Copy link
Contributor

@MTecknology MTecknology commented Aug 28, 2018 •
edited
Loading

What does this PR do?

This commit fixes a lot of issues with managing network interfaces on Debian-based distributions.

  • Cleaned up documentation/examples in states.network:
    • Updated debian-based distro comment
    • Fixed example of configuring a loopback device
    • Cleaned up copy/paste mistakes
    • Added more examples
    • Verified examples work on Debian 9
  • Added support for -ipaddrs and -ipv6ipaddrs to modules.debian_ip().
  • Added support for loopback devices to modules.debian_ip(). (Fixes: IPv6 Network states is incomplete #38672)
  • Added a bunch of unit tests for modules.debian_ip.build_interface().
  • Added support for dns_{nameservers,search} being a list or string.
  • Added support for multiple addresses per interface

What issues does this PR fix or reference?

Tests written?

Yes

Commits signed with GPG?

Yes

@MTecknology MTecknology mentioned this pull request Aug 28, 2018
Closed
@cachedout
Copy link
Contributor

@MTecknology Thanks for this. I'm afraid there is a failing test, though. Could you please take a look?

rallytime
rallytime approved these changes Aug 29, 2018
View reviewed changes
Copy link
Contributor

@rallytime rallytime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for writing that test!

@rallytime
Copy link
Contributor

@MTecknology That test is failing on CentOS 7. Can you take another look?

https://jenkinsci.saltstack.com/job/pr-kitchen-centos7-py3/job/PR-49355/10/

@rallytime rallytime merged commit e576b87 into saltstack:develop Aug 30, 2018
@MTecknology MTecknology deleted the debian-networking branch August 30, 2018 19:59
@garethgreenaway garethgreenaway added the bugfix-bckport will be be back-ported to an older release branch by creating a PR against that branch label Dec 4, 2018
@Ch3LL
Copy link
Contributor

Ch3LL commented Dec 6, 2018

@garethgreenaway what branch do you need this backported to?

@garethgreenaway
Copy link
Contributor

@Ch3LL should go back to 2018.3

@Ch3LL Ch3LL mentioned this pull request Dec 10, 2018
Merged
@Ch3LL Ch3LL added ZZZ[Done]-back-ported-bf RETIRED The pull request has been back-ported to an older branch. and removed bugfix-bckport will be be back-ported to an older release branch by creating a PR against that branch labels Dec 10, 2018
cachedout pushed a commit that referenced this pull request Dec 10, 2018
Merge pull request #50804 from Ch3LL/bp-49355
b266e8b 
Back-port #49355 to 2018.3
This was referenced Dec 20, 2018
Closed
Merged
@MTecknology MTecknology mentioned this pull request Mar 11, 2020
Merged
@waynew waynew added the has master-port port to master has been created label Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garethgreenaway garethgreenaway garethgreenaway approved these changes

@rallytime rallytime rallytime approved these changes

Assignees
No one assigned
Labels
has master-port port to master has been created ZZZ[Done]-back-ported-bf RETIRED The pull request has been back-ported to an older branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IPv6 Network states is incomplete
6 participants
@MTecknology @cachedout @rallytime @Ch3LL @garethgreenaway @waynew