Add hide_output option to cmd state/exec module #44840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have `output_loglevel` for controlling logging, but no corresponding option to suppress the output from the command from being returned. This adds a `hide_output` option to do that. Additionally, this removes the rest of the references to the long-since-deprecated `quiet` argument from the cmd execution module, and adds a warning to states which use this argument. `quiet` appears to have been incompletely removed following its deprecation. It was not being passed to _check_loglevel(), so it was essentially ignored, but it was still being accepted as an argument by several functions. Those references to what has for some time now been a no-op argument are now removed.
|
re-run centos |
garethgreenaway
approved these changes
Dec 8, 2017
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have
output_loglevelfor controlling logging, but no corresponding option to suppress the output from the command from being returned. This adds ahide_outputoption to do that.Additionally, this removes the rest of the references to the long-since-deprecated
quietargument from the cmd execution module, and adds a warning to states which use this argument.quietappears to have been incompletely removed following its deprecation. It was not being passed to _check_loglevel(), so it was essentially ignored, but it was still being accepted as an argument by several functions. Those references to what has for some time now been a no-op argument are now removed.Resolves #30842.