groupadd module: string does not have attribute 'extend', plus homogeneous cmd parm building
#43105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aogier, thanks for your PR! By analyzing the history of the files in this pull request, we identified @techhat, @thatch45 and @rallytime to be potential reviewers. |
|
rebased on 2016.11 |
aogier
changed the title
aogier
changed the title
aogier
changed the title
cmd parm building
terminalmage
approved these changes
Sep 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It fixes no-member errors in
cmdbuilding (eg. extend() on tuples or strings). It also unifiescmdcreation across the module, hopefully making it easier to maintain it.What issues does this PR fix or reference?
closes #43086