Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(kitchen): add pre-salted FreeBSD-12.0 box for local testing #172

Merged

Conversation

myii
Copy link
Member

@myii myii commented Oct 27, 2019

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Follows on from #171.

Describe the changes you're proposing

Introduce a pre-salted FreeBSD Vagrant box for local testing, using:

$ INSTANCE=freebsd-120-2019-2-py3 \
  && export KITCHEN_LOCAL_YAML=kitchen.vagrant.yml
$ bin/kitchen verify ${INSTANCE}

This Vagrant box has been kindly prepared (and provided) by @krionbsd.

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@aboe76 aboe76 merged commit 6cfdb9b into saltstack-formulas:master Oct 30, 2019
@aboe76
Copy link
Member

aboe76 commented Oct 30, 2019

merged it.

@myii myii deleted the ci/add-pre-salted-FreeBSD-Vagrant-box branch October 30, 2019 21:14
@myii
Copy link
Member Author

myii commented Oct 30, 2019

Thanks.

@saltstack-formulas-travis

🎉 This PR is included in version 0.43.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants