Skip to content
This repository has been archived by the owner on Jan 30, 2023. It is now read-only.

Commit

Permalink
Move import stmts to top and correct doc
Browse files Browse the repository at this point in the history
  • Loading branch information
guojing0 committed Jul 1, 2022
1 parent 0c6a176 commit c2242cb
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 21 deletions.
17 changes: 7 additions & 10 deletions src/sage/rings/polynomial/multi_polynomial_libsingular.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,10 @@ from sage.rings.integer cimport Integer
from sage.rings.integer import GCD_list
from sage.rings.number_field.number_field_base cimport NumberField

from sage.rings.number_field.order import is_NumberFieldOrder
from sage.categories.number_fields import NumberFields
from sage.rings.qqbar import QQbar

from sage.structure.element import coerce_binop

from sage.structure.parent cimport Parent
Expand Down Expand Up @@ -5488,7 +5492,7 @@ cdef class MPolynomial_libsingular(MPolynomial):

def global_height(self, prec=None):
"""
Return the absolute logarithmic height of the polynomial.
Return the projective height of the polynomial.
INPUT:
- ``prec`` -- desired floating point precision (default:
Expand All @@ -5513,25 +5517,18 @@ cdef class MPolynomial_libsingular(MPolynomial):
sage: exp(f.global_height())
1
"""
from sage.schemes.projective.projective_space import ProjectiveSpace
#from sage.schemes.projective.projective_morphism import _number_field_from_algebraics
from sage.rings.number_field.order import is_NumberFieldOrder
from sage.categories.number_fields import NumberFields
from sage.rings.qqbar import QQbar
if prec is None:
prec = 53

K = self.base_ring()
if K in NumberFields() or is_NumberFieldOrder(K):
f = self
#elif K is QQbar:
# f = self._number_field_from_algebraics()
else:
raise TypeError("Must be over a Numberfield or a Numberfield Order or QQbar.")

from sage.schemes.projective.projective_space import ProjectiveSpace
P = ProjectiveSpace(K, f.number_of_terms()-1)
proj_point = P.point(f.coefficients())
return proj_point.global_height()
return P.point(f.coefficients()).global_height()

def gradient(self):
"""
Expand Down
18 changes: 7 additions & 11 deletions src/sage/rings/polynomial/polynomial_element.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,9 @@ from sage.categories.morphism cimport Morphism
from sage.misc.superseded import deprecation_cython as deprecation
from sage.misc.cachefunc import cached_method

from sage.rings.number_field.order import is_NumberFieldOrder
from sage.categories.number_fields import NumberFields
from sage.rings.qqbar import QQbar

cpdef is_Polynomial(f):
"""
Expand Down Expand Up @@ -5745,7 +5748,7 @@ cdef class Polynomial(CommutativeAlgebraElement):

def global_height(self, prec=None):
"""
Return the absolute logarithmic height of the polynomial.
Return the projective height of the polynomial.
INPUT:
Expand All @@ -5763,25 +5766,18 @@ cdef class Polynomial(CommutativeAlgebraElement):
sage: exp(f.global_height)
3
"""
from sage.schemes.projective.projective_space import ProjectiveSpace
#from sage.schemes.projective.projective_morphism import _number_field_from_algebraics
from sage.rings.number_field.order import is_NumberFieldOrder
from sage.categories.number_fields import NumberFields
from sage.rings.qqbar import QQbar
if prec is None:
prec = 53

K = self.base_ring()
if K in NumberFields() or is_NumberFieldOrder(K):
f = self
#elif K is QQbar:
# f = self._number_field_from_algebraics()
else:
raise TypeError("Must be over a Numberfield or a Numberfield Order or QQbar.")
raise TypeError("Must be over a Numberfield or a Numberfield Order.")

from sage.schemes.projective.projective_space import ProjectiveSpace
P = ProjectiveSpace(K, f.number_of_terms()-1)
proj_point = P.point(f.coefficients())
return proj_point.global_height()
return P.point(f.coefficients()).global_height()

def exponents(self):
"""
Expand Down

0 comments on commit c2242cb

Please sign in to comment.