remove unused import + pep8 cleanup in modform/element #39611
+59
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit dd3e94c; changes) is ready! 🎉 |
dcoudert
approved these changes
Mar 1, 2025
| @@ -995,11 +993,11 @@ def period(self, M, prec=53): | |||
|
|
|||
| M = self.group()(M) | |||
| # coefficients of the matrix M | |||
| (b, c, d) = (M.b(), M.c() / N, M.d()) | |||
| b, c, d = (M.b(), M.c() / N, M.d()) | |||
There was a problem hiding this comment.
parenthesis are not needed on the right side either.
| if d == 0: | ||
| return R.zero() | ||
| if d < 0: | ||
| (b, c, d) = (-b, -c, -d) | ||
| b, c, d = (-b, -c, -d) |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 1, 2025
full pep8 cleanup in the modified file ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#39611 Reported by: Frédéric Chapoton Reviewer(s): David Coudert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
full pep8 cleanup in the modified file
📝 Checklist