Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace arithgroup.all imports #39428

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

tobiasdiez
Copy link
Contributor

...by more specific imports.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

github-actions bot commented Feb 1, 2025

Documentation preview for this PR (built with commit 765acec; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@user202729
Copy link
Contributor

The new code from … import … as … looks ugly. What about creating the alias in the source module in the first place, then in imports just import the alias directly?

@tobiasdiez
Copy link
Contributor Author

The new code from … import … as … looks ugly. What about creating the alias in the source module in the first place, then in imports just import the alias directly?

That might be a good idea, but I don't know what the original authors of that module wanted for people to use (the ugly import ... as ... construction is only there to prevent to many unrelated changes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants