add parameter immutable to transitive closure methods in sage/graphs/generic_graph.py
#39287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 8a5ec16; changes) is ready! 🎉 |
5 tasks
|
I'm not sure how to prevent the doctest error in This is certainly due to a change in the order of the vertices of a graph used somewhere... |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 10, 2025
…hs/generic_graph.py`
Following sagemath#39280, sagemath#39285, sagemath#39287, sagemath#39296 and discussions in sagemath#39177, we
add parameter immutable to methods in `sage/graphs/generic_graph.py`:
- `longest_cycle`
- `longest_path`
- `hamiltonian_path`
- and add tests in `cycle_basis`
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#39297
Reported by: David Coudert
Reviewer(s): Kwankyu Lee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #39280 and discussions in #39177, we add parameter
immutableto methods related to transitive closure insage/graphs/generic_graph.pyandsage/graphs/generic_graph_pyx.pyx:transitive_closure. We also fix the use of parameterloopsthat was previously ignoredtransitive_reductiontransitive_reduction_acyclicis_transitively_reduced. Here we ensure that the method accepts immutable digraphs.📝 Checklist
⌛ Dependencies