-
-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken docker/Dockerfile #38049
Fix broken docker/Dockerfile #38049
Conversation
Documentation preview for this PR (built with commit c1407f9; changes) is ready! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
It seems that this didn't work as expected see this run for beta7 and this one for beta8, explicitly in the first case:
In the run for beta4 the module still was found. @mkoeppe, do you have any idea what is missing? |
As mentioned in #37856 (comment) the
Dockerfile
is broken by #37856. This will be fixed in this PR.More precisely we replace
install_scripts
by appending$SAGE_ROOT/local/bin
to thebash
path variable. This does not affect Sage but ensures easy access togap
,maxima
, ... in abash
session (see #37856 (comment) ff).📝 Checklist
⌛ Dependencies