Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of SAGE_EXTCODE #37649

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Remove use of SAGE_EXTCODE #37649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fa95a8
src/sage/rings/function_field/function_field_polymod.py: Replace SAGE…
mkoeppe Mar 22, 2024
293bce8
src/sage/topologysimplicial_set_examples.py: Replace SAGE_EXTCODE by …
mkoeppe Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/sage/rings/function_field/function_field_polymod.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2449,9 +2449,10 @@ def _maximal_order_basis(self):
g = sum([v[i].numerator().subs(x) * y**i for i in range(len(v))])

if self.is_global():
import os
from sage.libs.singular.function import singular_function, lib
from sage.env import SAGE_EXTCODE
lib(SAGE_EXTCODE + '/singular/function_field/core.lib')
import sage.ext_data.singular.function_field as ff
lib(os.path.join(ff.__path__[0], 'core.lib'))
normalize = singular_function('core_normalize')

# Singular "normalP" algorithm assumes affine domain over
Expand Down
9 changes: 5 additions & 4 deletions src/sage/topology/simplicial_set_examples.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
import re
import os

from sage.env import SAGE_ENV
from sage.misc.cachefunc import cached_method, cached_function
from sage.misc.latex import latex
from sage.rings.infinity import Infinity
Expand Down Expand Up @@ -616,14 +615,16 @@ def ComplexProjectiveSpace(n):
latex_name='CP^{2}')
return K
if n == 3:
file = os.path.join(SAGE_ENV['SAGE_EXTCODE'], 'kenzo', 'CP3.txt')
from sage.ext_data import kenzo
file = os.path.join(kenzo.__path__[0], 'CP3.txt')
data = simplicial_data_from_kenzo_output(file)
v = [_ for _ in data.keys() if _.dimension() == 0][0]
K = SimplicialSet_finite(data, base_point=v, name='CP^3',
latex_name='CP^{3}')
return K
if n == 4:
file = os.path.join(SAGE_ENV['SAGE_EXTCODE'], 'kenzo', 'CP4.txt')
from sage.ext_data import kenzo
file = os.path.join(kenzo.__path__[0], 'CP4.txt')
data = simplicial_data_from_kenzo_output(file)
v = [_ for _ in data.keys() if _.dimension() == 0][0]
K = SimplicialSet_finite(data, base_point=v, name='CP^4',
Expand All @@ -649,7 +650,7 @@ def simplicial_data_from_kenzo_output(filename):

sage: from sage.topology.simplicial_set_examples import simplicial_data_from_kenzo_output
sage: from sage.topology.simplicial_set import SimplicialSet
sage: sphere = os.path.join(SAGE_ENV['SAGE_EXTCODE'], 'kenzo', 'S4.txt')
sage: sphere = os.path.join(os.path.join(sage.ext_data.kenzo.__path__[0], 'S4.txt'))
sage: S4 = SimplicialSet(simplicial_data_from_kenzo_output(sphere)) # needs pyparsing
sage: S4.homology(reduced=False) # needs pyparsing
{0: Z, 1: 0, 2: 0, 3: 0, 4: Z}
Expand Down
Loading