-
-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix link to tutorial in PDF docs. This fixes #35736. #36066
Conversation
There's nothing wrong with --- a/src/doc/en/website/root_index.html
+++ b/src/doc/en/website/root_index.html
@@ -113,7 +113,7 @@ title="SageMath Mathematical Software">
<div class="cell lang"><a href='html/en/index.html'>English</a></div>
<div class="cell doc">
<div class='entry lang-en'><a href='pdf/en/a_tour_of_sage/a_tour_of_sage.pdf'>A Tour of Sage</a></div>
-<div class='entry lang-en'><a href='pdf/en/tutorial/SageTutorial.pdf'>Tutorial</a></div>
+<div class='entry lang-en'><a href='pdf/en/tutorial/sage_tutorial.pdf'>Tutorial</a></div>
<div class='entry lang-en'><a href='pdf/en/thematic_tutorials/thematic_tutorials.pdf'>Thematic Tutorials</a></div>
<div class='entry lang-en'><a href='pdf/en/prep/prep_tutorials.pdf'>PREP Tutorials</a></div>
<div class='entry lang-en'><a href='pdf/en/constructions/constructions.pdf'>Constructions</a></div> This file is copied to sage/src/sage_docbuild/builders.py Line 449 in 0fd5967
|
Is there a reason to prefer one of these approaches to the other? They both just change a single string. Note that there is no particular consistency for naming conventions for PDF documents; in some languages we use "tutorial.pdf" (or variants) and in others "SageTutorial.pdf" (or variants). |
As filenames, I think that It seems that the issue is caused simply by a mistake I made to the file |
Seems like bikeshedding — the two changes seem equivalent to me — but here is your proposed version. |
Thanks. |
Documentation preview for this PR (built with commit 97c9900; changes) is ready! 🎉 |
Fix link to PDF tutorial (English) in docs. This should fix #35736.
The document name for the English tutorial is broken: it doesn't match the name expected in the index.html file for the documentation. So we change the document name.
📝 Checklist
⌛ Dependencies