Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

first sketch for callable factorisations #35928

Merged
merged 4 commits into from
Jul 20, 2023
Merged

first sketch for callable factorisations #35928

merged 4 commits into from
Jul 20, 2023

Conversation

fchapoton
Copy link
Contributor

Implement a simple substitution mechanism for "Factorization" instances, used when factorising polynomials for example.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

dcoudert
dcoudert suggested changes Jul 12, 2023
View reviewed changes
@github-actions
Copy link

Documentation preview for this PR (built with commit a8a7c35; changes) is ready! 🎉

dcoudert
dcoudert approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vbraun vbraun merged commit 19501dd into sagemath:develop Jul 20, 2023
@mkoeppe mkoeppe added this to the sage-10.1 milestone Jul 20, 2023
@fchapoton fchapoton deleted the call_factor branch September 6, 2023 14:53
@fchapoton
Copy link
Contributor Author

Hmm, an interesting new bug has followed:

sage: g=(q-1)**-1
sage: factor(g)
(q - 1)^-1
sage: _(q=1)
0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoudert dcoudert dcoudert approved these changes

Assignees
No one assigned
Labels
c: symbolics
Projects
None yet
Milestone
sage-10.1
Development

Successfully merging this pull request may close these issues.
5 participants
@fchapoton @dcoudert @vbraun @kwankyu @mkoeppe