Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI build.yml, doc-build.yml: Fix handling of added files #35865

Merged
merged 1 commit into from
Jul 9, 2023
Merged

CI build.yml, doc-build.yml: Fix handling of added files #35865

merged 1 commit into from
Jul 9, 2023

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Jun 30, 2023

📚 Description

The CI change in #35652 did not handle the case of a PR that adds files correctly: the fallback to the non-incremental build would delete these files.
We fix it here.

Fixes

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe requested review from kwankyu and tobiasdiez June 30, 2023 14:23
@mkoeppe mkoeppe self-assigned this Jun 30, 2023
@github-actions
Copy link

Documentation preview for this PR (built with commit 4f0ebac; changes) is ready! 🎉

@mkoeppe mkoeppe requested a review from dimpase July 1, 2023 16:26
dimpase
dimpase approved these changes Jul 1, 2023
View reviewed changes
Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 1, 2023

Thanks. Can I set to "positive review" then?

@kwankyu kwankyu mentioned this pull request Jul 3, 2023
Closed
@vbraun vbraun merged commit 22693a7 into sagemath:develop Jul 9, 2023
@mkoeppe mkoeppe added this to the sage-10.1 milestone Jul 9, 2023
@mkoeppe mkoeppe deleted the ci_fix_incremental_build branch October 17, 2023 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimpase dimpase dimpase approved these changes

@kwankyu kwankyu Awaiting requested review from kwankyu

@tobiasdiez tobiasdiez Awaiting requested review from tobiasdiez

Assignees

@mkoeppe mkoeppe

Labels
p: critical / 2 t: bug
Projects
None yet
Milestone
sage-10.1
Development

Successfully merging this pull request may close these issues.
3 participants
@mkoeppe @dimpase @vbraun