Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage.misc.timing: Split out from sage.misc.misc #35816

Merged
merged 5 commits into from
Jul 1, 2023
Merged

sage.misc.timing: Split out from sage.misc.misc #35816

merged 5 commits into from
Jul 1, 2023

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Jun 23, 2023

📚 Description

Another step to make the problematic sage.misc.misc module smaller.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this Jun 23, 2023
@mkoeppe mkoeppe force-pushed the sage_misc_timing branch from 2e09755 to 30d4209 Compare June 23, 2023 16:46
dcoudert
dcoudert suggested changes Jun 24, 2023
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise, LGTM.

pkgs/sagemath-objects/MANIFEST.in Outdated
@@ -83,6 +83,7 @@ graft sage/libs/gmp

## FIXME: Needed for doctesting
include sage/misc/misc.* # walltime, cputime used in sage.doctest
include sage/misc/timing.p*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the comment # walltime, cputime used in sage.doctest should be moved on this line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed in af7bcf6

dcoudert
dcoudert approved these changes Jun 25, 2023
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 25, 2023

Thank you!

@vbraun vbraun merged commit 8341449 into sagemath:develop Jul 1, 2023
@mkoeppe mkoeppe added this to the sage-10.1 milestone Jul 1, 2023
jhpalmieri added a commit to jhpalmieri/sage that referenced this pull request Jul 8, 2023
@jhpalmieri
tests/benchmark.py: import cputime and walltime from sage.misc.timing
0d6c729 
(because of sagemath#35816)
@jhpalmieri jhpalmieri mentioned this pull request Jul 8, 2023
Merged
5 tasks
@mkoeppe mkoeppe deleted the sage_misc_timing branch April 25, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoudert dcoudert dcoudert approved these changes

Assignees

@mkoeppe mkoeppe

Labels
t: refactoring
Projects
None yet
Milestone
sage-10.1
Development

Successfully merging this pull request may close these issues.
4 participants
@mkoeppe @dcoudert @vbraun @kwankyu