Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the linter and add more checks #35720

Merged
merged 1 commit into from
Jun 11, 2023
Merged

Conversation

fchapoton
Copy link
Contributor

📚 Description

this is fixing, once again, the just-recently broken linter

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@fchapoton fchapoton changed the title fix the and add more checks fix the linter and add more checks Jun 4, 2023
@dimpase
Copy link
Member

dimpase commented Jun 4, 2023

a doctest error is introduced.

File "sage_setup/autogen/interpreters/__init__.py", line 163, in sage_setup.autogen.interpreters.build_interp
Failed example:
    with open(testdir + '/interp_rdf.c') as f:
        f.readline()
Expected:
    '/* Automatically generated by ... */\n'
Got:
    '/* Automatically generated by /__w/sage/sage/src/sage_setup/autogen/interpreters/generator.py.  Do not edit!\n'

Also, what's the reason to change linter codes to be checked?

@fchapoton
Copy link
Contributor Author

Thanks. It should be better now. Adding new checks was an opportunity, as they were failing only a few times each.

@github-actions
Copy link

github-actions bot commented Jun 4, 2023

Documentation preview for this PR (built with commit 0552f74) is ready! 🎉

@vbraun vbraun merged commit 5c9ee29 into sagemath:develop Jun 11, 2023
@mkoeppe mkoeppe added this to the sage-10.1 milestone Jun 11, 2023
@fchapoton fchapoton deleted the fix_linter2 branch July 16, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants