GAP: fix definition of 'Int' #35701
Merged
GAP: fix definition of 'Int' #35701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GAP Int type, like UInt, has the size of a machine pointer (at least on the usual desktop system architectures), not a machine int. I.e. on a typical 64bit OS it is a 64bit integer, not a 32bit integer. This often makes no difference on little endian systems but can have disastrous consequences for large values or on big endian systems. Also fix a copy&paste mistake in the `make_gap_integer` argument name.
|
error in compilation: sage/libs/gap/gap_includes.pxd:16:13: 'intptr_t' is not a type identifier |
add missing import
|
Documentation preview for this PR (built with commit db93a1a) is ready! 🎉 |
fchapoton
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GAP Int type, like UInt, has the size of a machine pointer (at least
on the usual desktop system architectures), not a machine int. I.e. on a
typical 64bit OS it is a 64bit integer, not a 32bit integer. This often
makes no difference on little endian systems but can have disastrous
consequences for large values or on big endian systems.
Also fix a copy&paste mistake in the
make_gap_integerargument name.