-
-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doctester: Check for consistency of # optional
annotations
#35620
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works well.
I was a bit concerned that this would slowdown doctesting slightly, but the concern seems imaginary.
Thank you! |
Test fail It seems that |
Sorry about this, will fix.
Yes, that's currently true. #35652 changes this (by first running a fast incremental build/test, then running a full build of the Sage and ptest --long) |
Tests still fail. Thats two strikes. Please don't make it three. |
…octested in src/sage/doctest/forker.py
Sorry about this. Fixed now. |
Documentation preview for this PR (built with commit ac1f1fe) is ready! 🎉 |
📚 Description
For example:
Resolves #35401
📝 Checklist
⌛ Dependencies