Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

givaro, zeromq: Add patches for GCC 13 support #35415

Merged
merged 4 commits into from
Apr 28, 2023
Merged

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Apr 1, 2023

📚 Description

Part of the fix for #35092.
Tested using tox -e docker-fedora-38-minimal -- givaro zeromq.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this Apr 1, 2023
@mkoeppe mkoeppe changed the title Support GCC 13 givaro, zeromq: Add patches for GCC 13 support Apr 2, 2023
@mkoeppe mkoeppe requested a review from dimpase April 16, 2023 00:29
Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@enriqueartal
Copy link
Contributor

Is it a good idea to mix gcc13 and gfortran12? Allowing gfortran13 is possible and seems to work

@dimpase
Copy link
Member

dimpase commented Apr 24, 2023

I can't imagine a problem with using a different version of gfortran. We actually mix gfortran with clang/clang++, e.g. on macOS.

@dimpase
Copy link
Member

dimpase commented Apr 24, 2023

but indeed, the maximal version should be bumped up in https://github.com/sagemath/sage/blob/develop/build/pkgs/gfortran/spkg-configure.m4

@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: f209f0f

@vbraun vbraun merged commit 2bedb53 into sagemath:develop Apr 28, 2023
@mkoeppe mkoeppe added this to the sage-10.0 milestone Apr 28, 2023
@mkoeppe mkoeppe deleted the gcc_13 branch May 7, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants