-
-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
givaro
, zeromq
: Add patches for GCC 13 support
#35415
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Is it a good idea to mix gcc13 and gfortran12? Allowing gfortran13 is possible and seems to work |
I can't imagine a problem with using a different version of gfortran. We actually mix gfortran with clang/clang++, e.g. on macOS. |
but indeed, the maximal version should be bumped up in https://github.com/sagemath/sage/blob/develop/build/pkgs/gfortran/spkg-configure.m4 |
Documentation preview for this PR is ready! 🎉 |
📚 Description
Part of the fix for #35092.
Tested using
tox -e docker-fedora-38-minimal -- givaro zeromq
.📝 Checklist
⌛ Dependencies