Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the indentation in monsky_washnitzer.py to be *FOUR* spaces not two. #518

Closed
williamstein opened this issue Aug 29, 2007 · 6 comments
Closed

Comments

@williamstein
Copy link
Contributor

Component: basic arithmetic

Issue created by migration from https://trac.sagemath.org/ticket/518

@sagetrac-dmharvey
Copy link
Mannequin

sagetrac-dmharvey mannequin commented Aug 30, 2007

fix indentation

@sagetrac-dmharvey
Copy link
Mannequin

sagetrac-dmharvey mannequin commented Aug 30, 2007

comment:1

Attachment: mw-indentation.patch.gz

@sagetrac-dmharvey sagetrac-dmharvey mannequin modified the milestones: sage-2.9, sage-2.8.4 Sep 1, 2007
@williamstein
Copy link
Contributor Author

comment:3

I am unable to apply this patch:

hg_sage.sage: hg_sage.apply('mw-indentation.patch')
cd "/home/was/s/devel/sage" && hg status
cd "/home/was/s/devel/sage" && hg status
cd "/home/was/s/devel/sage" && hg import   "/home/was/Desktop/mw-indentation.patch"
applying /home/was/Desktop/mw-indentation.patch
sage/schemes/elliptic_curves/monsky_washnitzer.py
Hunk #1 FAILED at 60.
Hunk #7 FAILED at 1150.
Hunk #8 FAILED at 1215.
3 out of 9 hunks FAILED -- saving rejects to file sage/schemes/elliptic_curves/monsky_washnitzer.py.rej
abort: patch command failed: exited with status 1
sage:

And it really genuinely is mostly not applied.

@williamstein
Copy link
Contributor Author

comment:4
[11:18] <dmharvey> #518: okay, I guess I'll just go through and do it again at some point. I think the real problem here is to do with trac. I posted the patch a while back, but it didn't get rolled into the repository until now. But meanwhile you and robert had done a bunch of things.

@sagetrac-dmharvey
Copy link
Mannequin

sagetrac-dmharvey mannequin commented Sep 7, 2007

let's try that again

@williamstein
Copy link
Contributor Author

comment:5

Attachment: mw-indentation2.hg.gz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant