Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k-regular sequences: subsequences, forward/backward difference, partial sums #21325

Closed
dkrenn opened this issue Aug 24, 2016 · 62 comments
Closed

k-regular sequences: subsequences, forward/backward difference, partial sums #21325

dkrenn opened this issue Aug 24, 2016 · 62 comments
Labels
c: combinatorics p: major / 3 t: enhancement
Milestone
sage-9.6

Comments

@dkrenn
Copy link
Contributor

dkrenn commented Aug 24, 2016

Implement subsequences and forward/backward differences and partial sums.

See also meta ticket #21202

Depends on #21318

CC: @galipnik

Component: combinatorics

Author: Daniel Krenn, Clemens Heuberger

Branch/Commit: 7bc6722

Reviewer: Clemens Heuberger, Daniel Krenn

Issue created by migration from https://trac.sagemath.org/ticket/21325
@dkrenn dkrenn added this to the sage-7.4 milestone Aug 24, 2016
@dkrenn
Copy link
Contributor Author

dkrenn commented Aug 24, 2016

Branch: u/dkrenn/sequences/k-regular-subseq

@dkrenn

This comment has been minimized.

Sign in to view
@dkrenn
Copy link
Contributor Author

dkrenn commented Aug 24, 2016

Last 10 new commits:

d8a9173doctesting rmul, lmul and one_hadamard
01495cbextend to negative shifts in subsequence
b76bf4efactor out subsequence to separat ticket
a4e4bd5subsequence
26842f4missing_value=0
41bc288quasi-cherry-pick of pad_right of k-regular-guess branch
3023233rewrite to make subsequence more efficient (dynamically add kernel)
51e7d72minor rewrite
9311636allow b to be a dict
624e6c0forward/backward difference

@dkrenn
Copy link
Contributor Author

dkrenn commented Aug 24, 2016

Commit: 624e6c0

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 25, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

45d9e67minor rewrites
c430158partial sums
7eb93e1minor rewrites to use existing stuff better

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 25, 2016

Changed commit from 624e6c0 to 7eb93e1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 25, 2016

Changed commit from 7eb93e1 to 0f89159

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 25, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

5919120doctesting all parameters in coefficient_of_word
c7243a6Merge tag '7.4.beta1' into t/21295/sequences/recognizable
4012778Merge branch 't/21295/sequences/recognizable' into t/21203/sequences/k-regular
5dbedabfix doctests (experimental warning)
143ea73fix building of docs (no idea why it failed)
6247a7fMerge branch 't/21203/sequences/k-regular' into t/21318/sequences/rec-basic-arith
0f89159Merge branch 't/21318/sequences/rec-basic-arith' into t/21325/sequences/k-regular-subseq

@dkrenn

This comment has been minimized.

Sign in to view
@dkrenn dkrenn changed the title k-regular sequences: subsequences, forward/backward difference k-regular sequences: subsequences, forward/backward difference, partial sums Aug 25, 2016
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 26, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

e7d2114minor correction in doc
0fc3d42solve troubles with doc-building
d5c378dsolve troubles with doc-building
291faf9Merge branch 't/21203/sequences/k-regular' into t/21318/sequences/rec-basic-arith
019c161remove zero()
a2fe6f3Merge branch 't/21318/sequences/rec-basic-arith' into t/21325/sequences/k-regular-subseq
e4cec17minor correction in doc

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 26, 2016

Changed commit from 0f89159 to e4cec17

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 26, 2016

Changed commit from e4cec17 to 3a4e849

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 26, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

e03a32fMerge tag '7.4.beta2' into t/21180/cantor_product_comb
642cceeMerge branch 't/21180/cantor_product_comb' into t/21203/sequences/k-regular
352751eMerge tag '7.4.beta2' into t/21295/sequences/recognizable
914640fMerge branch 't/21295/sequences/recognizable' into t/21203/sequences/k-regular
c0ade99Merge branch 't/21203/sequences/k-regular' into t/21318/sequences/rec-basic-arith
3a4e849Merge branch 't/21318/sequences/rec-basic-arith' into t/21325/sequences/k-regular-subseq

@cheuberg
Copy link
Contributor

cheuberg commented Jan 5, 2017

comment:8

patchbot python3 plugin fails

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 24, 2017

Changed commit from 3a4e849 to fc6c3f5

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 24, 2017

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

4fe1a56Merge tag '7.5' into t/21295/sequences/recognizable
5848353Python3: __nonzero__
4a43407Python3: izip
4970cf5Python3: absolute import
e33a3c9Merge branch 't/21295/sequences/recognizable' into t/21203/sequences/k-regular
4da9796Merge branch 't/21203/sequences/k-regular' into t/21318/sequences/rec-basic-arith
13b536ePython3: absolut import
5919c4dMerge branch 't/21203/sequences/k-regular' into t/21318/sequences/rec-basic-arith
9086b64Merge branch 't/21318/sequences/rec-basic-arith' into t/21325/sequences/k-regular-subseq
fc6c3f5Python3: xrange

@dkrenn
Copy link
Contributor Author

dkrenn commented Jan 24, 2017

comment:10

Replying to @cheuberg:

patchbot python3 plugin fails

Fixed.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 6, 2018

Changed commit from fc6c3f5 to 0c83557

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 6, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

c2bf1b8Merge tag '8.1' into u/dkrenn/sequences/recognizable
fef79b2Merge branch 'u/dkrenn/sequences/recognizable' into u/dkrenn/sequences/k-regular
8eda76eMerge branch 'u/dkrenn/sequences/k-regular' into u/dkrenn/sequences/rec-basic-arith
0c83557Merge branch 'u/dkrenn/sequences/rec-basic-arith' into u/dkrenn/sequences/k-regular-subseq

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 29, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

5dbdcbbMerge tag '8.7' into u/dkrenn/sequences/recognizable
d17def8Merge branch 'u/dkrenn/sequences/recognizable' into u/dkrenn/sequences/k-regular
2b998baMerge branch 'u/dkrenn/sequences/k-regular' into u/dkrenn/sequences/rec-basic-arith
1f8c2a1Merge branch 'u/dkrenn/sequences/rec-basic-arith' into u/dkrenn/sequences/k-regular-subseq

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 9, 2022

Changed commit from 4cc1a75 to e7e3f2a

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 9, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

e7e3f2aTrac #21325 review comment 10: remove comment

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 12, 2022

Changed commit from e7e3f2a to ce43370

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 12, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

c9e7260Revert "Trac #21325 review comment 10: remove comment"
ce43370Trac #21325 review comment 10: comment range in kernel

@dkrenn
Copy link
Contributor Author

dkrenn commented Jan 12, 2022

comment:38

Replying to @cheuberg:

  1. subsequence: I am not so sure about the comment on the various ranges (and consequently, the tests testing that the range of c is large enough): It seems that no predefined range is used (anymore?), everything is generated dynamically. The only thing which actually matters is termination of the procedure, and if I am not mistaken, then -|b| \le f \le max(a, |b|) always holds which implies termination.

Ok.

I propose to remove or amend the comment.

I have now amended a comment. Please have a look.

@cheuberg
Copy link
Contributor

comment:39

Replying to @dkrenn:

Replying to @cheuberg:

  1. subsequence: I am not so sure about the comment on the various ranges (and consequently, the tests testing that the range of c is large enough): It seems that no predefined range is used (anymore?), everything is generated dynamically. The only thing which actually matters is termination of the procedure, and if I am not mistaken, then -|b| \le f \le max(a, |b|) always holds which implies termination.

Ok.

I propose to remove or amend the comment.

I have now amended a comment. Please have a look.

Thank you, LGTM.

The docbuild failure of the patchbot seems to be unrelated.

@cheuberg
Copy link
Contributor

comment:40

While reviewing #32921, I had one more look at this ticket, and found one more item to discuss.

  1. I think that the last commits here removed all usage of the new function pad_right introduced in this ticket, so we might as well delete that function.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 23, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

7bc6722Trac #21325 review comment 21: remove unneccessary helper pad_right

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 23, 2022

Changed commit from ce43370 to 7bc6722

@dkrenn
Copy link
Contributor Author

dkrenn commented Jan 23, 2022

comment:42

Replying to @cheuberg:

  1. I think that the last commits here removed all usage of the new function pad_right introduced in this ticket, so we might as well delete that function.

Removed.

@vbraun
Copy link
Member

vbraun commented Jan 31, 2022

Changed branch from u/dkrenn/sequences/k-regular-subseq to 7bc6722

@vbraun vbraun closed this as completed in 494fbe3 Jan 31, 2022
This was referenced Dec 29, 2022
Open
Closed
@galipnik galipnik mentioned this issue Sep 25, 2022
Closed
dkrenn added a commit to dkrenn/sage that referenced this issue May 25, 2023
@dkrenn
Merge branch 't/21319/sequences/rec-hash' into t/21204/sequences/k-re…
5ce5276 
…gular-guess

* t/21319/sequences/rec-hash:
  Trac sagemath#21319: fix punctuation
  Trac sagemath#21318: rmul/lmul preserve identity for multiplying by 1
  Trac sagemath#21325: fixup test .subsequence being identity
  Trac sagemath#21318: rmul/lmul preserve identity for multiplying by 1
  Trac sagemath#21325: use (new) decorator minimize_result
  Trac sagemath#21325: remove empty lines, fix punctuation
  Trac sagemath#21325: remove iteritems
  Trac sagemath#21318: fix rmul/lmul issues
  Trac sagemath#21318: use "correct" 1
  Trac sagemath#21318: use tensor_product in method hadamard_product
  Trac sagemath#21318: use is_trivial_zero in doctest of _neg_
  Trac sagemath#21318: use (new) .linear_representation in doctests
  Trac sagemath#21318: fix empty lines and punctuation
  Trac sagemath#21318: decorator minimize_result
  Trac sagemath#21203 review issue 10: use "raise ... from None" where approriate
dkrenn added a commit to dkrenn/sage that referenced this issue May 25, 2023
@dkrenn
Merge branch 't/21319/sequences/rec-hash' into t/21204/sequences/k-re…
3c634df 
…gular-guess

* t/21319/sequences/rec-hash: (2107 commits)
  Follow-up from Trac sagemath#21325 review comment 19: shift_left+right: test equality
  Trac sagemath#21325 review comment 19: shift_left, shift_right
  Trac sagemath#21325 review comment 18: deal with remaining block vectors
  Trac sagemath#21325 review comment 17: simpler (more readable) construction of block matrix
  Trac sagemath#21325 review comment 14+15: rewrite construction dict
  Trac sagemath#21325 review comment 13: use .linear representation in examples partial_sum
  Trac sagemath#21325 review comment 12: fixup docstring partial_sums
  Trac sagemath#21325 review comment 11: simplify construction and code for left vector
  Trac sagemath#21325 review comment 9: add comment in inner loop
  Trac sagemath#21325 review comment 8: more rewriting to use block structure
  Trac sagemath#21325 review comment 8: rewrite subsequences to use block matrices
  Trac sagemath#21325 review comment 7: rewrite dict-constrution
  Trac sagemath#21325 review comment 6: test matrices of output
  Trac sagemath#21325 review comment 4: explicitly state vector in example
  Trac sagemath#21325 review comment 5: use .linear_representation
  Trac sagemath#21325 review comment 4: simplify lineare representation of example-sequence (subsequence)
  Trac sagemath#21325 review comment 3: revise description of parameter b of subsequence
  Trac sagemath#21325 review comment 2: PEP8 in examples of pad_right
  Trac sagemath#21325 review comment 1: fix docstring formatting in pad_right
  Updated SageMath version to 9.4
  ...
dkrenn added a commit to dkrenn/sage that referenced this issue Jul 4, 2023
@dkrenn
Merge branch 't/21204/sequences/k-regular-guess' into t/21343/k-regul…
fb5fb62 
…ar-warning

* t/21204/sequences/k-regular-guess:
  Trac sagemath#21204: fix punctuation
  Trac sagemath#21319: fix punctuation
  Trac sagemath#21318: rmul/lmul preserve identity for multiplying by 1
  Trac sagemath#21325: fixup test .subsequence being identity
  Trac sagemath#21318: rmul/lmul preserve identity for multiplying by 1
  Trac sagemath#21325: use (new) decorator minimize_result
  Trac sagemath#21325: remove empty lines, fix punctuation
  Trac sagemath#21325: remove iteritems
  Trac sagemath#21318: fix rmul/lmul issues
  Trac sagemath#21318: use "correct" 1
  Trac sagemath#21318: use tensor_product in method hadamard_product
  Trac sagemath#21318: use is_trivial_zero in doctest of _neg_
  Trac sagemath#21318: use (new) .linear_representation in doctests
  Trac sagemath#21318: fix empty lines and punctuation
  Trac sagemath#21318: decorator minimize_result
  Trac sagemath#21203 review issue 10: use "raise ... from None" where approriate
dkrenn added a commit to dkrenn/sage that referenced this issue Jul 4, 2023
@dkrenn
Merge branch 't/21204/sequences/k-regular-guess' into t/21343/k-regul…
4af416c 
…ar-warning

* t/21204/sequences/k-regular-guess: (2107 commits)
  Follow-up from Trac sagemath#21325 review comment 19: shift_left+right: test equality
  Trac sagemath#21325 review comment 19: shift_left, shift_right
  Trac sagemath#21325 review comment 18: deal with remaining block vectors
  Trac sagemath#21325 review comment 17: simpler (more readable) construction of block matrix
  Trac sagemath#21325 review comment 14+15: rewrite construction dict
  Trac sagemath#21325 review comment 13: use .linear representation in examples partial_sum
  Trac sagemath#21325 review comment 12: fixup docstring partial_sums
  Trac sagemath#21325 review comment 11: simplify construction and code for left vector
  Trac sagemath#21325 review comment 9: add comment in inner loop
  Trac sagemath#21325 review comment 8: more rewriting to use block structure
  Trac sagemath#21325 review comment 8: rewrite subsequences to use block matrices
  Trac sagemath#21325 review comment 7: rewrite dict-constrution
  Trac sagemath#21325 review comment 6: test matrices of output
  Trac sagemath#21325 review comment 4: explicitly state vector in example
  Trac sagemath#21325 review comment 5: use .linear_representation
  Trac sagemath#21325 review comment 4: simplify lineare representation of example-sequence (subsequence)
  Trac sagemath#21325 review comment 3: revise description of parameter b of subsequence
  Trac sagemath#21325 review comment 2: PEP8 in examples of pad_right
  Trac sagemath#21325 review comment 1: fix docstring formatting in pad_right
  Updated SageMath version to 9.4
  ...
dkrenn added a commit to dkrenn/sage that referenced this issue Aug 3, 2023
@dkrenn
Merge branch 't/21343/k-regular-warning' into t/22964/k-regular-bounded
ad011e3 
* t/21343/k-regular-warning: (2124 commits)
  Follow-up from Trac sagemath#21325 review comment 19: shift_left+right: test equality
  Trac sagemath#21325 review comment 19: shift_left, shift_right
  Trac sagemath#21325 review comment 18: deal with remaining block vectors
  Trac sagemath#21325 review comment 17: simpler (more readable) construction of block matrix
  Trac sagemath#21325 review comment 14+15: rewrite construction dict
  Trac sagemath#21325 review comment 13: use .linear representation in examples partial_sum
  Trac sagemath#21325 review comment 12: fixup docstring partial_sums
  Trac sagemath#21325 review comment 11: simplify construction and code for left vector
  Trac sagemath#21325 review comment 9: add comment in inner loop
  Trac sagemath#21325 review comment 8: more rewriting to use block structure
  Trac sagemath#21325 review comment 8: rewrite subsequences to use block matrices
  Trac sagemath#21325 review comment 7: rewrite dict-constrution
  Trac sagemath#21325 review comment 6: test matrices of output
  Trac sagemath#21325 review comment 4: explicitly state vector in example
  Trac sagemath#21325 review comment 5: use .linear_representation
  Trac sagemath#21325 review comment 4: simplify lineare representation of example-sequence (subsequence)
  Trac sagemath#21325 review comment 3: revise description of parameter b of subsequence
  Trac sagemath#21325 review comment 2: PEP8 in examples of pad_right
  Trac sagemath#21325 review comment 1: fix docstring formatting in pad_right
  Updated SageMath version to 9.4
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorics p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.6
Development

No branches or pull requests
5 participants
@vbraun @mkoeppe @cheuberg @dkrenn @mathzeta