Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event modulation to peri_event.py #56

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

heathlarsson
Copy link
Collaborator

pull request to debug swr_modulated_units function

@ryanharvey1
Copy link
Owner

looks like minor linting issues

You can check the tests https://github.com/ryanharvey1/neuro_py/actions/runs/13422423741/job/37497999965?pr=56

Also, you can add static typing to the inputs and outputs. For example:

def reorder_channels(
    file_path: str,
    n_channels: int,
    channel_order: List[int],
    precision: str = "int16",
    num_processes: int = 8,  # Adjust based on your CPU cores
) -> str:

@ryanharvey1
Copy link
Owner

you can also add your function to the neuro_py/process/init.py

You can see how the other functions are listed and imported there

@ryanharvey1
Copy link
Owner

I think your function should take as inputs spikes and ripples instead of loading them which caused circular imports. Above, I fixed the circular imports in a less than optimal way, and it would be better to keep all functions in peri_event very low level.

@ryanharvey1 ryanharvey1 changed the title Update peri_event.py Add event modulation to peri_event.py Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants