feat(build): add rustc check #353
Conversation
ashleygwilliams
added
needs tests
ashleygwilliams
force-pushed
the
rustc-version-check
branch
2 times, most recently
from
e41850c to
8fa264c
Compare
Cargo.toml
Outdated
| @@ -19,6 +19,7 @@ indicatif = "0.9.0" | |||
| lazy_static = "1.1.0" | |||
| openssl = { version = '0.10.11', optional = true } | |||
| parking_lot = "0.6" | |||
| rustc_version = "0.2.3" | |||
There was a problem hiding this comment.
FWIW using this crate can be problematic sometimes until djc/rustc-version-rs#11 has been fixed, and in general determining just the minor version of rustc is pretty lightweight
There was a problem hiding this comment.
thanks! and good to know. happy to do it without the crate.
ashleygwilliams
force-pushed
the
rustc-version-check
branch
from
b5373f4 to
4866996
Compare
ashleygwilliams
force-pushed
the
rustc-version-check
branch
2 times, most recently
from
e59c95a to
0ace242
Compare
ashleygwilliams
removed
needs tests
ashleygwilliams
changed the title
ashleygwilliams
force-pushed
the
rustc-version-check
branch
from
0ace242 to
f45322c
Compare
|
chatted with @alexcrichton and we are gonna punt on testing this at the moment. it's tricky and it's probably best to just test the binary which will require a bunch of work and prevent the release today. i'll test manually to ensure it works as expected and prioritize the testing strat for this week and next release |
|
currently i can only get it to this: test strategy - compile in beta or nightly, |
|
ok, this works locally for me |
|
i might fix it to log the full version cuz that 29 looks weird |
There was a problem hiding this comment.
127 michael@eva-03 ~/Code/wasm-pack (git)-[rustc-version-check] % cargo run -- build :(
Finished dev [unoptimized + debuginfo] target(s) in 0.12s
Running `target/debug/wasm-pack build`
| [1/9] 🦀 Checking `rustc` version...
Your version of Rust, '29', is not supported. Please install Rust version 1.30.0 or higher.
1 michael@eva-03 ~/Code/wasm-pack (git)-[rustc-version-check] % PATH="" ./target/debug/wasm-pack build :(
| [1/9] 🦀 Checking `rustc` version...
We can't figure out what your Rust version is- which means you might not have Rust installed. Please install Rust version 1.30.0 or higher.
Verified this works as intended! Great work Ashley!
fixes #351