Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pki_types::UnixTime instead of local Time type #175

Merged
merged 4 commits into from
Sep 12, 2023
Merged

Use pki_types::UnixTime instead of local Time type #175

merged 4 commits into from
Sep 12, 2023

Conversation

djc
Copy link
Member

@djc djc commented Sep 12, 2023

No description provided.

@djc djc requested review from cpu and ctz September 12, 2023 15:32
@codecov
Copy link

codecov bot commented Sep 12, 2023 •
edited
Loading

Codecov Report

Merging #175 (69dbe68) into main (58ab3c0) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
- Coverage   96.70%   96.69%   -0.01%     
==========================================
  Files          17       17              
  Lines        4518     4506      -12     
==========================================
- Hits         4369     4357      -12     
  Misses        149      149
Files Changed Coverage Δ
src/cert.rs 97.47% <ø> (ø)
src/crl/mod.rs 97.42% <ø> (ø)
src/ring_algs.rs 100.00% <ø> (ø)
src/crl/types.rs 99.53% <100.00%> (ø)
src/end_entity.rs 100.00% <100.00%> (ø)
src/time.rs 95.36% <100.00%> (-0.32%) ⬇️
src/verify_cert.rs 97.80% <100.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

cpu
cpu reviewed Sep 12, 2023
View reviewed changes
cpu
cpu approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⏳

@djc djc added this pull request to the merge queue Sep 12, 2023
Merged via the queue into main with commit 2ed9a43 Sep 12, 2023
@djc djc deleted the unix-time branch September 12, 2023 17:06
@djc
Copy link
Member Author

djc commented Sep 13, 2023

Published alpha.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpu cpu cpu approved these changes

@ctz ctz ctz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djc @cpu @ctz