Fix recent CI failures #3041
Merged
Fix recent CI failures #3041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
madsmtm
requested review from
msiglreith,
daxpedda and
kchibisov
as code owners
|
Kind of weird to request a review and then merge right after. Anyway, the usual way to test things like that is to run clippy on msrv. |
The review requests are automatic because of code ownership. |
|
Ah, yeah, they get trigger when you convert from draft to actual PR. |
|
Clippy on MSRV isn't always useful; a lot of the lints have been improved in the several versions since. |
Yeah sorry about that, I wanted to unassign you before I did so, but it seems I forgot |
kchibisov
pushed a commit
to kchibisov/winit
that referenced
this pull request
Oct 17, 2023
* Fix new clippy lints * Fix nightly documentation warnings
kchibisov
pushed a commit
that referenced
this pull request
Oct 21, 2023
* Fix new clippy lints * Fix nightly documentation warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We really need to work on making our CI more stable against upstream updates like this, but oh well, let's just fix it for now.