Removed the pesky reference for WindowEvent::ScaleFactorChanged #2869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See this #1456 -- There was a demand to have a way to adjust sizes during scale factor changes. I personally think that this event must be entirely removed in a favor of merging it with resize, but this reference is needed for now... I don't remember the exact discussion from where it came from, but it's not that hard to find on the issue tracker. |
|
@atomicf32 the methods are async. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer: I have no idea if it was important that there was a reference for new_inner_size, I just think it is pointless.
I have not tested on linux nor mac os, but it seems to work on windows.