Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Bump ndk/ndk-glue to 0.3 and use constants for event ident #1847

Merged
merged 1 commit into from
Jan 30, 2021

Conversation

MarijnS95
Copy link
Member

Following the changes in 1 this bumps ndk and ndk-glue to 0.3 and uses the new constants. The minor version has been bumped to prevent applications from running an older winit (without #1826) with a newer ndk/ndk-glue that does not pass this ident through the data pointer anymore.

  • Tested on all platforms changed
  • Compilation warnings were addressed
  • cargo fmt has been run on this branch
  • cargo doc builds successfully
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

Following the changes in [1] this bumps ndk and ndk-glue to 0.3 and uses
the new constants. The minor version has been bumped to prevent
applications from running an older winit (without rust-windowing#1826) with a newer
ndk/ndk-glue that does not pass this `ident` through the `data` pointer
anymore.

[1]: rust-mobile/ndk#112
@MarijnS95
Copy link
Member Author

CC @msiglreith

@MarijnS95 MarijnS95 merged commit bd99eb1 into rust-windowing:master Jan 30, 2021
@MarijnS95 MarijnS95 deleted the ndk-update branch January 30, 2021 18:43
@MarijnS95
Copy link
Member Author

   Uploading winit v0.24.0 (/home/runner/work/winit/winit)
error: api errors (status 200 OK): crate version `0.24.0` is already uploaded
Error: Process completed with exit code 101.

Has cargo publish always done this?

@msiglreith
Copy link
Member

Yes, it just checks if the cargo toml changed and then tries to publish

@MarijnS95
Copy link
Member Author

Yes, it just checks if the cargo toml changed and then tries to publish

@msiglreith Yes, but only few merges to master cause Publish to run and subsequently get a completely unnecessary build failure. Why is it running for this PR but not others?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants