macOS: Wake up run loop immediately when request redraw is received #1812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr1sunshine
force-pushed
the
mr1sunshine/fix-macos-request-redraw
branch
from
c759d50 to
14768fe
Compare
maroider
reviewed
Jan 1, 2021
mr1sunshine
force-pushed
the
mr1sunshine/fix-macos-request-redraw
branch
from
14768fe to
04f1ae5
Compare
ArturKovacs
approved these changes
Apr 5, 2021
mr1sunshine
force-pushed
the
mr1sunshine/fix-macos-request-redraw
branch
from
04f1ae5 to
940503f
Compare
|
@ArturKovacs should be good now, please proceed with merge. |
maroider
reviewed
Apr 5, 2021
We allow to have RunLoop running only on the main thread. Which means if we call Window::request_redraw() from other the thread then we have to wait until some other event arrives on the main thread. That situation is even worse when we have ControlFlow set to the `Wait` mode then user will not ever render anything.
mr1sunshine
force-pushed
the
mr1sunshine/fix-macos-request-redraw
branch
from
940503f to
1be11a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We allow to have RunLoop running only on the main thread. Which means if
we call Window::request_redraw() from other the thread then we have to
wait until some other event arrives on the main thread. That situation
is even worse when we have ControlFlow set to the
Waitmode then userwill not ever render anything.
The goal of this PR is a try to fix macOS-related part of the issue #1763 I was not sure if it is a good idea to wake up RunLoop directly from the AppState, so please correct me with the right place to add this logic if needed.
cargo fmthas been run on this branchcargo docbuilds successfullyCHANGELOG.mdif knowledge of this change could be valuable to users