Remove logical pixel handling from scroll events #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixpulvis
reviewed
Feb 27, 2020
kchibisov
reviewed
Mar 2, 2020
kchibisov
approved these changes
Mar 3, 2020
Osspial
reviewed
Mar 6, 2020
chrisduerr
force-pushed
the
lets_get_physical
branch
from
cf783f4 to
553b519
Compare
Merged
kchibisov
force-pushed
the
lets_get_physical
branch
from
a01d0a6 to
aca6b7d
Compare
chrisduerr
force-pushed
the
lets_get_physical
branch
from
aca6b7d to
fc18824
Compare
kchibisov
force-pushed
the
lets_get_physical
branch
2 times, most recently
from
564f55a to
e96aad2
Compare
This removes the `LogicalPosition` from the `PixelDelta`, since all other APIs have been switched to use `PhysicalPosition` instead too. Fixes rust-windowing#1406.
kchibisov
force-pushed
the
lets_get_physical
branch
from
e96aad2 to
8fc18f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
LogicalPositionfrom thePixelDelta, since allother APIs have been switched to use
PhysicalPositioninstead too.It also seems like
LineDeltawas using both logical and physicalsizes, depending on platform. I've changed this to explicitly take a
PhysicalPositionparameter to force a uniform return value.I'm not entirely sure which platform uses which kind of pixel sizes by
default, so I've made the assumption that both the web and macOS
platforms deliver their events in LogicalPositions.
Fixes #1406.