Reimplement NativeDisplayMode on iOS for #1310 #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goddessfreya
added
DS - ios
P - high
ghost
suggested changes
Dec 22, 2019
Co-Authored-By: Aleksi Juvani <3168386+aleksijuvani@users.noreply.github.com>
ghost
approved these changes
Dec 22, 2019
| impl Drop for NativeDisplayMode { | ||
| fn drop(&mut self) { | ||
| unsafe { | ||
| let () = msg_send![self.0, release]; |
There was a problem hiding this comment.
@aleksijuvani @simlay I was just merging master back into my winit-glutin-next and noticed that the assert_main_thread has been removed. Is this intentional?
There was a problem hiding this comment.
I think it's fine to pass this around multiple threads. If we see a crash here we'll revisit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1310.
I pretty much did exactly as #1310 (comment) said. I'm not big on the name NativeDisplayMode nor that it's nearly the exact same code from the macOS logic but I figure it's an okay first pass.
cargo fmthas been run on this branchcargo docbuilds successfullyCHANGELOG.mdif knowledge of this change could be valuable to users