On Wayland, under mutter(GNOME Wayland), fix CSD being behind the status bar, when starting window in maximized mode #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goddessfreya
added
DS - wayland
C - waiting on maintainer
|
This PR shows the correct behaviour for me. |
elinorbgr
reviewed
Dec 19, 2019
CHANGELOG.md
Outdated
| @@ -1,6 +1,7 @@ | |||
| # Unreleased | |||
|
|
|||
| - On Wayland, fix cursor icon updates on window borders when using CSD. | |||
| - On Wayland, under mutter(GNOME Wayland), fix CSD being behind the status bar, when stating window in maximized mode. | |||
There was a problem hiding this comment.
Is this a typo for "starting" (missing "r") ?
There was a problem hiding this comment.
I had to force push, because I have to alter commit message(the same typo).
…tus bar, when starting window in maximized mode Mutter can reposition window on resize, if it is behind mutter's "bounding box". So, when you start winit window in maximized mode with CSD, mutter places its CSD behind the GNOME's status bar initially, and then sends configure with the exact same size as your current window. If winit decides to optimize calling frame.resize(..) in this case, we won't call set_geometry(we're calling it through resize) and GNOME won't reposition your window to be inside the "bounding box", which is not a desired behavior for the end user.
kchibisov
force-pushed
the
please-mutter
branch
from
b8fc50a to
0471413
Compare
kchibisov
changed the title
elinorbgr
approved these changes
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GNOME places maximized window CSD behind the status bar, and in the same time it moves any window crossing the "bounding box"(screen edges + status bar's bottom edge on top) into it on the next resize. So the main problem is GNOME placing window in a wrong place initially.
That gif shows the behavior I'm talking about. You don't need maximize to repro it.
The question why mutter places our window in a wrong place initially is still flying in the air...
cargo fmthas been run on this branchCHANGELOG.mdif knowledge of this change could be valuable to userscc @Will-W
Fixes #1312