Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement windows focus key press/release on Windows #1307

Merged
merged 3 commits into from
Dec 27, 2019
Merged

Implement windows focus key press/release on Windows #1307

merged 3 commits into from
Dec 27, 2019

Conversation

Osspial
Copy link
Contributor

@Osspial Osspial commented Dec 4, 2019 •
edited
Loading

  • Tested on all platforms changed
  • Compilation warnings were addressed
  • cargo fmt has been run on this branch
  • cargo doc builds successfully
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users

Implements #1272 on Windows.

@goddessfreya goddessfreya added DS - windows C - waiting on author Waiting for a response or another PR labels Dec 4, 2019
goddessfreya
goddessfreya reviewed Dec 4, 2019
View reviewed changes
@Osspial Osspial marked this pull request as ready for review December 22, 2019 06:31
murarth and others added 3 commits December 22, 2019 01:32
@murarth @Osspial
X11: Sync key press/release with window focus
48b6f65 
* When a window loses focus, key release events are issued for all pressed keys
* When a window gains focus, key press events are issued for all pressed keys
* Adds `is_synthetic` field to `WindowEvent` variant `KeyboardInput`
  to indicate that these events are synthetic.
* Adds `is_synthetic: false` to `WindowEvent::KeyboardInput` events issued
  on all other platforms
@Osspial
Implement windows focus key press/release on Windows
6f5c01d
@Osspial
Docs
0b5833f
@goddessfreya goddessfreya added C - waiting on maintainer A maintainer must review this code and removed C - waiting on author Waiting for a response or another PR labels Dec 22, 2019
@Osspial Osspial merged commit cc206d3 into rust-windowing:master Dec 27, 2019
@goddessfreya goddessfreya mentioned this pull request Dec 29, 2019
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goddessfreya goddessfreya goddessfreya left review comments

Assignees
No one assigned
Labels
C - waiting on maintainer A maintainer must review this code DS - windows
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Osspial @goddessfreya @murarth