Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Window::set_minimized method #985

Closed
felixrabe opened this issue Jun 26, 2019 · 2 comments
Closed

Add Window::set_minimized method #985

felixrabe opened this issue Jun 26, 2019 · 2 comments
Labels
C - needs investigation Issue must be confirmed and researched DS - macos DS - wayland DS - windows DS - x11 S - api Design and usability S - enhancement Wouldn't this be the coolest?

Comments

@felixrabe
Copy link
Contributor

I was surprised to find that such a method was missing: https://docs.rs/winit/0.20.0-alpha1/winit/window/struct.Window.html
@felixrabe felixrabe mentioned this issue Jun 26, 2019
Closed
@Osspial
Copy link
Contributor

Osspial commented Jun 26, 2019

Yeah, we should absolutely expose this. This should be trivial to implement on Windows.

@goddessfreya goddessfreya added S - api Design and usability DS - macos DS - wayland DS - windows DS - x11 S - enhancement Wouldn't this be the coolest? C - needs investigation Issue must be confirmed and researched labels Jun 26, 2019
SuperiorJT added a commit to SuperiorJT/winit that referenced this issue Jun 27, 2019
@SuperiorJT
Expose set_minimized. Implement for macOS (rust-windowing#985)
55614c0
@SuperiorJT SuperiorJT mentioned this issue Jun 27, 2019
Merged
11 tasks
SuperiorJT added a commit to SuperiorJT/winit that referenced this issue Jun 27, 2019
@SuperiorJT @vberger
Implement set_minimized for Wayland (rust-windowing#985)
900e711 
Co-Authored-By: Victor Berger <vberger@users.noreply.github.com>
SuperiorJT added a commit to SuperiorJT/winit that referenced this issue Jun 28, 2019
@SuperiorJT
Implement set_minimized for Windows (rust-windowing#985)
b7d0c16
SuperiorJT added a commit to SuperiorJT/winit that referenced this issue Jun 28, 2019
@SuperiorJT
Remove debug logs (rust-windowing#985)
149594b
SuperiorJT added a commit to SuperiorJT/winit that referenced this issue Nov 6, 2019
@SuperiorJT
Stop setting window styles when minimizing (rust-windowing#985)
f118870
SuperiorJT added a commit to SuperiorJT/winit that referenced this issue Dec 16, 2019
@SuperiorJT
Add stub for WASM (rust-windowing#985)
b96e415
Osspial added a commit that referenced this issue Dec 22, 2019
@SuperiorJT @vberger
@murarth @goddessfreya @Osspial
Window::set_minimized (#985) (#990)
82889e2 
* Expose set_minimized. Implement for macOS (#985)

* Implement set_minimized for Wayland (#985)

Co-Authored-By: Victor Berger <vberger@users.noreply.github.com>

* Implement set_minimized for Windows (#985)

* Remove debug logs (#985)

* Implement Window::set_minimized for X11

* Remove extra param from set_window_flags call

* Cargo fmt

* Add example of usage

* Update changelog

* Update feature matrix

* Cargo fmt

* Update example to remove unnecessary event var

* Stop setting window styles when minimizing (#985)

* Add stub for WASM (#985)

Co-authored-by: Victor Berger <vberger@users.noreply.github.com>
Co-authored-by: Murarth <murarth@gmail.com>
Co-authored-by: Freya Gentz <zegentzy@protonmail.com>
Co-authored-by: Osspial <osspial@gmail.com>
@kchibisov
Copy link
Member

I guess this bug should be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C - needs investigation Issue must be confirmed and researched DS - macos DS - wayland DS - windows DS - x11 S - api Design and usability S - enhancement Wouldn't this be the coolest?
Milestone
No milestone
Development

No branches or pull requests
4 participants
@felixrabe @Osspial @goddessfreya @kchibisov