-
Notifications
You must be signed in to change notification settings - Fork 948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EventsLoop::wakeup independent of interrupt #175
Comments
Btw, I'd be happy to implement this. I thought discussion was an appropriate first step, though. |
I've thought about this a bit more, and I think it would be appropriate for the |
Digging into the source a bit, it looks like there's some leftover |
Does anyone have feedback about this? |
@jwilm just thought I'd let you know that #136 and in particular this comment are related to (and probably supersede) this. |
Agreed that the pending |
…orking-again Get magicleap working again
…indowing#176) * use geometry() to get monitor size * add .change file * Update linux-monitor-size.md
The method
EventsLoop::interrupt()
is currently serving the dual purpose ofrun_forever
andpoll_events
Running the wakeup code when you only care about 1. simply wastes cycles.
I'm proposing that a second method,
EventsLoop::wakeup()
is added to allow performing these tasks independently. An alternative design would be removing theinterrupted
flag altogether and allow the closure passed torun_forever
andpoll_events
to return a flag indicating their desire to continue or halt.The text was updated successfully, but these errors were encountered: