Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add target names to Dataset #373

Merged
merged 12 commits into from
Feb 3, 2025
Merged

Add target names to Dataset #373

merged 12 commits into from
Feb 3, 2025

Conversation

relf
Copy link
Member

@relf relf commented Feb 1, 2025

This PR supersedes the PR #256 and complete the implementation. See also #70.

@relf relf marked this pull request as ready for review February 1, 2025 18:25
Copy link

codecov bot commented Feb 1, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 19 lines in your changes missing coverage. Please review.

Project coverage is 35.37%. Comparing base (a30e5f1) to head (c67f244).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/dataset/impl_dataset.rs 57.57% 14 Missing ⚠️
...rithms/linfa-trees/src/decision_trees/algorithm.rs 50.00% 2 Missing ⚠️
src/dataset/iter.rs 60.00% 2 Missing ⚠️
src/correlation.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #373      +/-   ##
==========================================
+ Coverage   34.93%   35.37%   +0.44%     
==========================================
  Files          96       96              
  Lines        6334     6371      +37     
==========================================
+ Hits         2213     2254      +41     
+ Misses       4121     4117       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@relf relf merged commit 9744625 into rust-ml:master Feb 3, 2025
22 checks passed
@relf relf deleted the target-naming branch February 3, 2025 10:34
This was referenced Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants