Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add dont_frag option #556

Closed
wants to merge 2 commits into from
Closed

feat: add dont_frag option #556

wants to merge 2 commits into from

Conversation

cathaysia
Copy link

@cathaysia cathaysia commented Feb 20, 2025 •
edited
Loading

fix #318

Thomasdezeeuw
Thomasdezeeuw requested changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@Thomasdezeeuw Thomasdezeeuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll also need a getter for this.

And we'll need tests.

@cathaysia cathaysia force-pushed the feat/df branch 11 times, most recently from 1a36d92 to e0035f9 Compare February 21, 2025 03:58
@cathaysia
Copy link
Author

what happend about this ci?

Thomasdezeeuw
Thomasdezeeuw requested changes Feb 24, 2025
View reviewed changes
Copy link
Collaborator

@Thomasdezeeuw Thomasdezeeuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now has way too many unrelated changes. Please don't overload a pr with unrelated stuff.

If you want to make multiple changes, please open multiple prs.

src/sys/windows.rs
@@ -1022,36 +1035,41 @@ impl FromRawSocket for crate::Socket {
}
}

#[test]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you make these changes? Please revert.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you don't warp #[test] in cfg(test), then these code will be compiled into the binary.

@cathaysia
feat: wrap test in #[test]
08ae506 
Signed-off-by: loongtao.zhang <loongtao.zhang@outlook.com>
@cathaysia cathaysia force-pushed the feat/df branch 2 times, most recently from 9e44a2c to 680d8ad Compare February 25, 2025 02:47
@cathaysia
feat: add dont_frag option
55d0e54 
Signed-off-by: loongtao.zhang <loongtao.zhang@outlook.com>
@cathaysia cathaysia closed this Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thomasdezeeuw Thomasdezeeuw Thomasdezeeuw requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support set IP_DONTFRAG
2 participants
@cathaysia @Thomasdezeeuw