Make all cli functions and structs crate-private #2829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rustin170506
force-pushed
the
rustin-patch-cli
branch
3 times, most recently
from
53d442a to
5c78f72
Compare
|
@kinnison Could you please take a look? Thanks! |
|
@hi-rustin have you checked that there is no lint on Windows builds? |
I checked the CI relevant build log and found no warnings, do I still need to check it manually? |
|
@rbtcollins @kinnison Do you have time to help look at it? Thanks! |
rbtcollins
reviewed
Aug 17, 2021
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Rustin170506
force-pushed
the
rustin-patch-cli
branch
from
ca1d526 to
19dff91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #2730