Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace emojis when NO_EMOJI env variable present #676

Merged
merged 2 commits into from
Mar 22, 2021

Conversation

matt-lebl
Copy link
Contributor

When the NO_EMOJI environment variable is set, replace/eliminate emojis in output.

For instance, without NO_EMOJI set (normal behaviour):
Screen Shot 2021-03-19 at 2 25 48 AM

With NO_EMOJI set:
Screen Shot 2021-03-19 at 2 26 30 AM

Addresses #364.

@shadows-withal
Copy link
Member

Out of curiosity, is there any prior work for this environment variable in other projects? Is there some sort of standard naming here that works with multiple CLI applications when you have it set?

@matt-lebl
Copy link
Contributor Author

Unfortunately, not that I could find. I started with issue #364 and looked for an environment variable to suit it, eventually settling on NO_EMOJI after the similar NO_COLOR from https://no-color.org. There is however no precedent that I could find for NO_EMOJI in particular.

@shadows-withal shadows-withal merged commit b350945 into rust-lang:main Mar 22, 2021
@shadows-withal
Copy link
Member

@all-contributors please add @blerchy for code

@allcontributors
Copy link
Contributor

@fmoko

I've put up a pull request to add @blerchy! 🎉

ppp3 pushed a commit to ppp3/rustlings that referenced this pull request May 23, 2022
Replace emojis when NO_EMOJI env variable present
dmoore04 pushed a commit to dmoore04/rustlings that referenced this pull request Sep 11, 2022
Replace emojis when NO_EMOJI env variable present
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants