This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
Apply suggestion #63
Merged
Apply suggestion #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probably because we need to enable clippy lint groups (but I don't want to spend time on this right now)
|
Update to fix newer clippy lints not important for compiletest rustfix, will fix later (or remove) |
|
Want to land this right now so I can whip up the lib/bin split next and publish it all as 0.2? |
|
Wait, after making this build again, of course, sorry, thought I already did this |
Looks like they're failing on nightly and hopefully we'll get enough coverage in rust-lang/rust itself to cover these use cases.
alexcrichton
pushed a commit
to killercup/rust
that referenced
this pull request
May 4, 2018
Uses branch from <rust-lang/rustfix#63> until we publish a new release.
djrenren
pushed a commit
to djrenren/compiletest
that referenced
this pull request
Aug 26, 2019
Uses branch from <rust-lang/rustfix#63> until we publish a new release.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf. rust-lang/rust#50084