Fix artifact table display #1805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lqd
approved these changes
Jan 17, 2024
Kobzol
force-pushed
the
artifact-table-fix
branch
from
67ffbd6 to
5662a80
Compare
The table was broken because nightly has recently stopped shipping `libtest.so`, and one piece of the code was accessing `undefined` artifact data. This commit makes component handling more robust.
Kobzol
force-pushed
the
artifact-table-fix
branch
from
5662a80 to
95486ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The table was broken because nightly has recently stopped shipping
libtest.so, and one piece of the code was accessingundefinedartifact data. This commit makes component handling more robust.