Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #99187

Closed
wants to merge 34 commits into from
Closed

Conversation

Dylan-DPC
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

oli-obk and others added 30 commits July 7, 2022 10:46
…Simulacrum

allow unions with mutable references and tuples of allowed types

We currently allow shared references in unions, but not mutable references. That seems somewhat inconsistent. So let's allow all references, and while we are at it, let's make sure the set of allowed types is closed under tuples.

This will need T-lang FCP (at least).

Then remove the `tagged_unions` feature, since we do not plan to stabilize any more of it.
Closes rust-lang#55149
`UnsafeCell` blocks niches inside its nested type from being available outside

fixes rust-lang#87341

This implements the plan by `@eddyb` in rust-lang#87341 (comment)

Somewhat related PR (not strictly necessary, but that cleanup made this PR simpler): rust-lang#94527
…non_exhaustive, r=oli-obk

check non_exhaustive attr and private fields for transparent types

Fixes rust-lang#78586.
Add some autolabels for A-bootstrap and T-infra
…=lnicola

⬆️ rust-analyzer

r? ``@ghost``
@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jul 12, 2022
@Dylan-DPC
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Contributor

bors commented Jul 12, 2022

📌 Commit de5950f has been approved by Dylan-DPC

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 12, 2022
@bors
Copy link
Contributor

bors commented Jul 12, 2022

⌛ Testing commit de5950f with merge ada51e60893f55e3da2eaf1c8e3cde8440fb8e0f...

@bors
Copy link
Contributor

bors commented Jul 12, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 12, 2022
@rust-log-analyzer
Copy link
Collaborator

The job aarch64-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

---- [ui] src/test/ui/invalid/invalid-llvm-passes.rs stdout ----
diff of stderr:

1 error: failed to run LLVM passes: unknown pass name 'unknown-pass'
+ thread '<unnamed>' panicked at 'assertion failed: `(left == right)`
+   left: `LLVMing`,
+   left: `LLVMing`,
+  right: `Codegenning`', $COMPILER_DIR/rustc_codegen_ssa/src/back/write.rs:1494:21
+ stack backtrace:
+    0:     0xffff793c187c - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::hf6d3e5233ab5c32a
+    1:     0xffff7941e934 - core::fmt::write::h4e1a2f76f8e5c93a
+    2:     0xffff793b3d98 - std::io::Write::write_fmt::h797dabc6f9926b87
+    3:     0xffff793c46ec - std::panicking::default_hook::{{closure}}::h146a12c772b3b6db
+    4:     0xffff793c43e8 - std::panicking::default_hook::h40be46032d14cd3d
+    5:     0xffff7a3a6954 - rustc_driver[d444e7272f607202]::DEFAULT_HOOK::{closure#0}::{closure#0}
+    6:     0xffff793c4ea4 - std::panicking::rust_panic_with_hook::hc44eefe15148d043
+    7:     0xffff793c4cec - std::panicking::begin_panic_handler::{{closure}}::h2bedc385e7459238
+    8:     0xffff793c1dc4 - std::sys_common::backtrace::__rust_end_short_backtrace::h1e18079ce2f9a15f
+    9:     0xffff793c49ec - rust_begin_unwind
+   10:     0xffff7938160c - core::panicking::panic_fmt::h6750ff8f7796de68
+   11:     0xffff7941b3e0 - core::panicking::assert_failed_inner::h5287120d772ad7c2
+   12:     0xffff7a14fac0 - core[ae2479b836263677]::panicking::assert_failed::<rustc_codegen_ssa[367127703d545860]::back::write::MainThreadWorkerState, rustc_codegen_ssa[367127703d545860]::back::write::MainThreadWorkerState>
+   13:     0xffff7a61e840 - rustc_codegen_ssa[367127703d545860]::back::write::start_executing_work::<rustc_codegen_llvm[5f50436ea3ed4deb]::LlvmCodegenBackend>::{closure#4}
+   14:     0xffff7a61710c - std[ec9d766acf43f5c0]::sys_common::backtrace::__rust_begin_short_backtrace::<<rustc_codegen_llvm[5f50436ea3ed4deb]::LlvmCodegenBackend as rustc_codegen_ssa[367127703d545860]::traits::backend::ExtraBackendMethods>::spawn_thread<rustc_codegen_ssa[367127703d545860]::back::write::start_executing_work<rustc_codegen_llvm[5f50436ea3ed4deb]::LlvmCodegenBackend>::{closure#4}, core[ae2479b836263677]::result::Result<rustc_codegen_ssa[367127703d545860]::back::write::CompiledModules, ()>>::{closure#0}, core[ae2479b836263677]::result::Result<rustc_codegen_ssa[367127703d545860]::back::write::CompiledModules, ()>>
+   15:     0xffff7a774f2c - <<std[ec9d766acf43f5c0]::thread::Builder>::spawn_unchecked_<<rustc_codegen_llvm[5f50436ea3ed4deb]::LlvmCodegenBackend as rustc_codegen_ssa[367127703d545860]::traits::backend::ExtraBackendMethods>::spawn_thread<rustc_codegen_ssa[367127703d545860]::back::write::start_executing_work<rustc_codegen_llvm[5f50436ea3ed4deb]::LlvmCodegenBackend>::{closure#4}, core[ae2479b836263677]::result::Result<rustc_codegen_ssa[367127703d545860]::back::write::CompiledModules, ()>>::{closure#0}, core[ae2479b836263677]::result::Result<rustc_codegen_ssa[367127703d545860]::back::write::CompiledModules, ()>>::{closure#1} as core[ae2479b836263677]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0}
+   16:     0xffff793cfc38 - std::sys::unix::thread::Thread::new::thread_start::h1843d9ec46b614d1
+   17:     0xffff7915e624 - start_thread
+   18:     0xffff7926d49c - <unknown>
+   19:                0x0 - <unknown>
+ error: internal compiler error: unexpected panic
+ 
+ note: the compiler unexpectedly panicked. this is a bug.
+ 
+ 
+ note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md
+ 
+ note: rustc 1.64.0-nightly (ada51e608 2022-07-12) running on aarch64-unknown-linux-gnu
+ 
+ note: compiler flags: -Z threads=1 -C codegen-units=1 -Z ui-testing -Z deduplicate-diagnostics=no -C strip=debuginfo -C prefer-dynamic -C rpath -C debuginfo=0 -C passes=unknown-pass -Z new-llvm-pass-manager=yes
+ query stack during panic:
+ end of query stack
3 error: aborting due to previous error
4 
---
To only update this specific test, also pass `--test-args invalid/invalid-llvm-passes.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/invalid/invalid-llvm-passes.rs" "-Zthreads=1" "--target=aarch64-unknown-linux-gnu" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Cstrip=debuginfo" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/invalid/invalid-llvm-passes" "-A" "unused" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/aarch64-unknown-linux-gnu/native/rust-test-helpers" "-Cpasses=unknown-pass" "-Z" "new-llvm-pass-manager=yes" "-L" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/invalid/invalid-llvm-passes/auxiliary"
stdout: none
--- stderr -------------------------------
error: failed to run LLVM passes: unknown pass name 'unknown-pass'
thread '<unnamed>' panicked at 'assertion failed: `(left == right)`
  left: `LLVMing`,
  left: `LLVMing`,
 right: `Codegenning`', /checkout/compiler/rustc_codegen_ssa/src/back/write.rs:1494:21
stack backtrace:
   0:     0xffff793c187c - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::hf6d3e5233ab5c32a
   1:     0xffff7941e934 - core::fmt::write::h4e1a2f76f8e5c93a
   2:     0xffff793b3d98 - std::io::Write::write_fmt::h797dabc6f9926b87
   3:     0xffff793c46ec - std::panicking::default_hook::{{closure}}::h146a12c772b3b6db
   4:     0xffff793c43e8 - std::panicking::default_hook::h40be46032d14cd3d
   5:     0xffff7a3a6954 - rustc_driver[d444e7272f607202]::DEFAULT_HOOK::{closure#0}::{closure#0}
   6:     0xffff793c4ea4 - std::panicking::rust_panic_with_hook::hc44eefe15148d043
   7:     0xffff793c4cec - std::panicking::begin_panic_handler::{{closure}}::h2bedc385e7459238
   8:     0xffff793c1dc4 - std::sys_common::backtrace::__rust_end_short_backtrace::h1e18079ce2f9a15f
   9:     0xffff793c49ec - rust_begin_unwind
  10:     0xffff7938160c - core::panicking::panic_fmt::h6750ff8f7796de68
  11:     0xffff7941b3e0 - core::panicking::assert_failed_inner::h5287120d772ad7c2
  12:     0xffff7a14fac0 - core[ae2479b836263677]::panicking::assert_failed::<rustc_codegen_ssa[367127703d545860]::back::write::MainThreadWorkerState, rustc_codegen_ssa[367127703d545860]::back::write::MainThreadWorkerState>
  13:     0xffff7a61e840 - rustc_codegen_ssa[367127703d545860]::back::write::start_executing_work::<rustc_codegen_llvm[5f50436ea3ed4deb]::LlvmCodegenBackend>::{closure#4}
  14:     0xffff7a61710c - std[ec9d766acf43f5c0]::sys_common::backtrace::__rust_begin_short_backtrace::<<rustc_codegen_llvm[5f50436ea3ed4deb]::LlvmCodegenBackend as rustc_codegen_ssa[367127703d545860]::traits::backend::ExtraBackendMethods>::spawn_thread<rustc_codegen_ssa[367127703d545860]::back::write::start_executing_work<rustc_codegen_llvm[5f50436ea3ed4deb]::LlvmCodegenBackend>::{closure#4}, core[ae2479b836263677]::result::Result<rustc_codegen_ssa[367127703d545860]::back::write::CompiledModules, ()>>::{closure#0}, core[ae2479b836263677]::result::Result<rustc_codegen_ssa[367127703d545860]::back::write::CompiledModules, ()>>
  15:     0xffff7a774f2c - <<std[ec9d766acf43f5c0]::thread::Builder>::spawn_unchecked_<<rustc_codegen_llvm[5f50436ea3ed4deb]::LlvmCodegenBackend as rustc_codegen_ssa[367127703d545860]::traits::backend::ExtraBackendMethods>::spawn_thread<rustc_codegen_ssa[367127703d545860]::back::write::start_executing_work<rustc_codegen_llvm[5f50436ea3ed4deb]::LlvmCodegenBackend>::{closure#4}, core[ae2479b836263677]::result::Result<rustc_codegen_ssa[367127703d545860]::back::write::CompiledModules, ()>>::{closure#0}, core[ae2479b836263677]::result::Result<rustc_codegen_ssa[367127703d545860]::back::write::CompiledModules, ()>>::{closure#1} as core[ae2479b836263677]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0}
  16:     0xffff793cfc38 - std::sys::unix::thread::Thread::new::thread_start::h1843d9ec46b614d1
  17:     0xffff7915e624 - start_thread
  18:     0xffff7926d49c - <unknown>
  19:                0x0 - <unknown>
error: internal compiler error: unexpected panic

note: the compiler unexpectedly panicked. this is a bug.


note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md

note: rustc 1.64.0-nightly (ada51e608 2022-07-12) running on aarch64-unknown-linux-gnu

note: compiler flags: -Z threads=1 -C codegen-units=1 -Z ui-testing -Z deduplicate-diagnostics=no -C strip=debuginfo -C prefer-dynamic -C rpath -C debuginfo=0 -C passes=unknown-pass -Z new-llvm-pass-manager=yes
query stack during panic:
end of query stack
error: aborting due to previous error
------------------------------------------

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
  IMAGE: x86_64-gnu-tools
##[endgroup]
From https://github.com/rust-lang/rust
 * branch              master     -> FETCH_HEAD
Searching for toolstate changes between 1c7b36d4db582cb47513a6c7176baaec1c3346ab and 578f6d32357a920020ba8e2fc602b954e2901ba4
Submodules were updated
##[group]Run src/ci/scripts/verify-channel.sh
src/ci/scripts/verify-channel.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
---
>   |
>LL | #![feature(untagged_unions)]
>   |            ^^^^^^^^^^^^^^^ feature has been removed
>   |
>   = note: unions with `Copy` and `ManuallyDrop` fields are stable; there is no intent to stabilize more
>error[E0740]: unions cannot contain fields that may need dropping
>  --> $DIR/union.rs:LL:CC
>   |
>LL |         s: S,
>LL |         s: S,
>   |         ^^^^
>   |
>   = note: a type is guaranteed not to need dropping when it implements `Copy`, or when it is the special `ManuallyDrop<_>` type
>help: when the type does not implement `Copy`, wrap it inside a `ManuallyDrop<_>` and ensure it is manually dropped
>   |
>LL |         s: std::mem::ManuallyDrop<S>,
>   |            +++++++++++++++++++++++ +
>error: aborting due to 2 previous errors
>
>Some errors have detailed explanations: E0557, E0740.
>For more information about an error, try `rustc --explain E0557`.
---
>   |
>LL | #![feature(untagged_unions)]
>   |            ^^^^^^^^^^^^^^^ feature has been removed
>   |
>   = note: unions with `Copy` and `ManuallyDrop` fields are stable; there is no intent to stabilize more
>error: aborting due to previous error
>
>For more information about this error, try `rustc --explain E0557`.
>
---

---- compile_test stdout ----
diff of stderr:

-error: you are implementing `Clone` explicitly on a `Copy` type
+error[E0557]: feature has been removed
+  --> $DIR/derive.rs:1:12
    |
    |
-LL | / impl Clone for Qux {
-LL | |     fn clone(&self) -> Self {
-LL | |         Qux
-LL | |     }
-LL | | }
-   | |_^
+LL | #![feature(untagged_unions)]
    |
    |
-   = note: `-D clippy::expl-impl-clone-on-copy` implied by `-D warnings`
-note: consider deriving `Clone` or removing `Copy`
-   |
-   |
-LL | / impl Clone for Qux {
-LL | |     fn clone(&self) -> Self {
-LL | |         Qux
-LL | |     }
-LL | | }
-   | |_^
+   = note: unions with `Copy` and `ManuallyDrop` fields are stable; there is no intent to stabilize more
 
-error: you are implementing `Clone` explicitly on a `Copy` type
-   |
-   |
-LL | / impl<'a> Clone for Lt<'a> {
-LL | |     fn clone(&self) -> Self {
-LL | |         unimplemented!()
-LL | |     }
-LL | | }
-   | |_^
-   |
-note: consider deriving `Clone` or removing `Copy`
-   |
-   |
-LL | / impl<'a> Clone for Lt<'a> {
-LL | |     fn clone(&self) -> Self {
-LL | |         unimplemented!()
-LL | |     }
-LL | | }
-   | |_^
 
 
-error: you are implementing `Clone` explicitly on a `Copy` type
-   |
-   |
-LL | / impl Clone for BigArray {
-LL | |     fn clone(&self) -> Self {
-LL | |         unimplemented!()
-LL | |     }
-LL | | }
-   | |_^
-   |
-note: consider deriving `Clone` or removing `Copy`
-   |
-   |
-LL | / impl Clone for BigArray {
-LL | |     fn clone(&self) -> Self {
-LL | |         unimplemented!()
-LL | |     }
-LL | | }
-   | |_^
-
-error: you are implementing `Clone` explicitly on a `Copy` type
-   |
-   |
-LL | / impl Clone for FnPtr {
-LL | |     fn clone(&self) -> Self {
-LL | |         unimplemented!()
-LL | |     }
-LL | | }
-   | |_^
-   |
-note: consider deriving `Clone` or removing `Copy`
-   |
-   |
-LL | / impl Clone for FnPtr {
-LL | |     fn clone(&self) -> Self {
-LL | |         unimplemented!()
-LL | |     }
-LL | | }
-   | |_^
-
-error: you are implementing `Clone` explicitly on a `Copy` type
-   |
-   |
-LL | / impl<T: Clone> Clone for Generic2<T> {
-LL | |     fn clone(&self) -> Self {
-LL | |         Self(self.0.clone())
-LL | |     }
-LL | | }
-   | |_^
-   |
-note: consider deriving `Clone` or removing `Copy`
-   |
-   |
-LL | / impl<T: Clone> Clone for Generic2<T> {
-LL | |     fn clone(&self) -> Self {
-LL | |         Self(self.0.clone())
-LL | |     }
-LL | | }
-   | |_^
-error: aborting due to 5 previous errors
-
+For more information about this error, try `rustc --explain E0557`.
 
---
To only update this specific test, also pass `--test-args derive.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/clippy-driver" "tests/ui/derive.rs" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/test/ui" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/test/ui/derive.stage-id" "-A" "unused" "--emit=metadata" "-Dwarnings" "-Zui-testing" "-L" "dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps" "-L" "dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps" "--extern" "rustc_semver=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/librustc_semver-963bbd3f89834643.rlib" "--extern" "clippy_lints=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libclippy_lints-ff530e80824c3a36.rlib" "--extern" "if_chain=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libif_chain-03f75cdc6d4d3afc.rlib" "--extern" "derive_new=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps/libderive_new-71205fa4273edf27.so" "--extern" "syn=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libsyn-0c795f7a8756f15a.rlib" "--extern" "serde_derive=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps/libserde_derive-5411643be5ff72c2.so" "--extern" "tokio=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libtokio-dcc59fbd39a40970.rlib" "--extern" "futures=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libfutures-61ecef333190a996.rlib" "--extern" "quote=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libquote-021aec868151835c.rlib" "--extern" "serde=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libserde-46430df947b7dad0.rlib" "--extern" "clippy_utils=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libclippy_utils-b92911696ae4394a.rlib" "--extern" "parking_lot=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libparking_lot-aceff80e643e9fe7.rlib" "--extern" "itertools=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libitertools-cdd893c121eb00e4.rlib" "--extern" "regex=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libregex-7d13fa063f867ef0.rlib" "--edition=2021" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/test/ui/derive.stage-id.aux"
------------------------------------------

------------------------------------------
stderr:
stderr:
------------------------------------------
{"message":"feature has been removed","code":{"code":"E0557","explanation":"A feature attribute named a feature that has been removed.\n\nErroneous code example:\n\n```compile_fail,E0557\n#![feature(managed_boxes)] // error: feature has been removed\n```\n\nDelete the offending feature attribute.\n"},"level":"error","spans":[{"file_name":"tests/ui/derive.rs","byte_start":11,"byte_end":26,"line_start":1,"line_end":1,"column_start":12,"column_end":27,"is_primary":true,"text":[{"text":"#![feature(untagged_unions)]","highlight_start":12,"highlight_end":27}],"label":"feature has been removed","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"unions with `Copy` and `ManuallyDrop` fields are stable; there is no intent to stabilize more","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error[E0557]: feature has been removed\n  --> tests/ui/derive.rs:1:12\n   |\nLL | #![feature(untagged_unions)]\n   |            ^^^^^^^^^^^^^^^ feature has been removed\n   |\n   = note: unions with `Copy` and `ManuallyDrop` fields are stable; there is no intent to stabilize more\n\n"}
{"message":"For more information about this error, try `rustc --explain E0557`.","code":null,"level":"failure-note","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0557`.\n"}

------------------------------------------

---
-   |     ^^
+LL | #![feature(untagged_unions)]
+   |            ^^^^^^^^^^^^^^^ feature has been removed
    |
-   = note: `-D clippy::no-effect` implied by `-D warnings`
+   = note: unions with `Copy` and `ManuallyDrop` fields are stable; there is no intent to stabilize more
-error: statement with no effect
-  --> $DIR/no_effect.rs:96:5
-   |
-LL |     s2;
---
-   |     ^^^^^^^^^
-
-error: statement with no effect
-  --> $DIR/no_effect.rs:99:5
-   |
-LL |     Struct { field: 0 };
-   |     ^^^^^^^^^^^^^^^^^^^^
-error: statement with no effect
-  --> $DIR/no_effect.rs:100:5
-   |
-   |
-LL |     Struct { ..s };
-   |     ^^^^^^^^^^^^^^^
-error: statement with no effect
-  --> $DIR/no_effect.rs:101:5
-   |
-   |
-LL |     Union { a: 0 };
-   |     ^^^^^^^^^^^^^^^
-error: statement with no effect
-  --> $DIR/no_effect.rs:102:5
-   |
-LL |     Enum::Tuple(0);
-LL |     Enum::Tuple(0);
-   |     ^^^^^^^^^^^^^^^
-
-error: statement with no effect
-  --> $DIR/no_effect.rs:103:5
-   |
-LL |     Enum::Struct { field: 0 };
-   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
-error: statement with no effect
-  --> $DIR/no_effect.rs:104:5
-   |
-LL |     5 + 6;
---
-   |     ^^^^^^^^^
-
-error: statement with no effect
-  --> $DIR/no_effect.rs:115:5
-   |
-LL |     [42, 55][1];
-   |     ^^^^^^^^^^^^
-error: statement with no effect
-  --> $DIR/no_effect.rs:116:5
-   |
-   |
-LL |     (42, 55).1;
-   |     ^^^^^^^^^^^
-error: statement with no effect
-  --> $DIR/no_effect.rs:117:5
-   |
-   |
-LL |     [42; 55];
-   |     ^^^^^^^^^
-error: statement with no effect
-  --> $DIR/no_effect.rs:118:5
-   |
-   |
-LL |     [42; 55][13];
-   |     ^^^^^^^^^^^^^
-error: statement with no effect
-  --> $DIR/no_effect.rs:120:5
-   |
-   |
-LL |     || x += 5;
-   |     ^^^^^^^^^^
-error: statement with no effect
-  --> $DIR/no_effect.rs:122:5
-   |
-   |
-LL |     FooString { s: s };
-   |     ^^^^^^^^^^^^^^^^^^^
-
-error: binding to `_` prefixed variable with no side-effect
-   |
-   |
-LL |     let _unused = 1;
-   |     ^^^^^^^^^^^^^^^^
-   |
-   = note: `-D clippy::no-effect-underscore-binding` implied by `-D warnings`
-
-error: binding to `_` prefixed variable with no side-effect
-   |
-   |
-LL |     let _penguin = || println!("Some helpful closure");
-   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-
-error: binding to `_` prefixed variable with no side-effect
-   |
-   |
-LL |     let _duck = Struct { field: 0 };
-   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-
-error: binding to `_` prefixed variable with no side-effect
-   |
-   |
-LL |     let _cat = [2, 4, 6, 8][2];
-   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
-error: aborting due to 30 previous errors
-
+For more information about this error, try `rustc --explain E0557`.
 
---
To only update this specific test, also pass `--test-args no_effect.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/clippy-driver" "tests/ui/no_effect.rs" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/test/ui" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/test/ui/no_effect.stage-id" "-A" "unused" "--emit=metadata" "-Dwarnings" "-Zui-testing" "-L" "dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps" "-L" "dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps" "--extern" "rustc_semver=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/librustc_semver-963bbd3f89834643.rlib" "--extern" "clippy_lints=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libclippy_lints-ff530e80824c3a36.rlib" "--extern" "if_chain=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libif_chain-03f75cdc6d4d3afc.rlib" "--extern" "derive_new=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps/libderive_new-71205fa4273edf27.so" "--extern" "syn=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libsyn-0c795f7a8756f15a.rlib" "--extern" "serde_derive=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps/libserde_derive-5411643be5ff72c2.so" "--extern" "tokio=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libtokio-dcc59fbd39a40970.rlib" "--extern" "futures=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libfutures-61ecef333190a996.rlib" "--extern" "quote=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libquote-021aec868151835c.rlib" "--extern" "serde=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libserde-46430df947b7dad0.rlib" "--extern" "clippy_utils=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libclippy_utils-b92911696ae4394a.rlib" "--extern" "parking_lot=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libparking_lot-aceff80e643e9fe7.rlib" "--extern" "itertools=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libitertools-cdd893c121eb00e4.rlib" "--extern" "regex=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libregex-7d13fa063f867ef0.rlib" "--edition=2021" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/test/ui/no_effect.stage-id.aux"
------------------------------------------

------------------------------------------
stderr:
stderr:
------------------------------------------
{"message":"feature has been removed","code":{"code":"E0557","explanation":"A feature attribute named a feature that has been removed.\n\nErroneous code example:\n\n```compile_fail,E0557\n#![feature(managed_boxes)] // error: feature has been removed\n```\n\nDelete the offending feature attribute.\n"},"level":"error","spans":[{"file_name":"tests/ui/no_effect.rs","byte_start":232,"byte_end":247,"line_start":7,"line_end":7,"column_start":12,"column_end":27,"is_primary":true,"text":[{"text":"#![feature(untagged_unions)]","highlight_start":12,"highlight_end":27}],"label":"feature has been removed","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"unions with `Copy` and `ManuallyDrop` fields are stable; there is no intent to stabilize more","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error[E0557]: feature has been removed\n  --> tests/ui/no_effect.rs:7:12\n   |\nLL | #![feature(untagged_unions)]\n   |            ^^^^^^^^^^^^^^^ feature has been removed\n   |\n   = note: unions with `Copy` and `ManuallyDrop` fields are stable; there is no intent to stabilize more\n\n"}
{"message":"For more information about this error, try `rustc --explain E0557`.","code":null,"level":"failure-note","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0557`.\n"}

------------------------------------------

@bors
Copy link
Contributor

bors commented Jul 12, 2022

⌛ Testing commit de5950f with merge 123d1811afdced5558d8b6b4493f403be7272cf3...

@bors
Copy link
Contributor

bors commented Jul 12, 2022

⌛ Testing commit de5950f with merge 1ea6b9eda41b69a8cbd489d82b783cc466c38fd2...

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
>   |
>LL | #![feature(untagged_unions)]
>   |            ^^^^^^^^^^^^^^^ feature has been removed
>   |
>   = note: unions with `Copy` and `ManuallyDrop` fields are stable; there is no intent to stabilize more
>error: aborting due to previous error
>
>For more information about this error, try `rustc --explain E0557`.
>
---
>   |
>LL | #![feature(untagged_unions)]
>   |            ^^^^^^^^^^^^^^^ feature has been removed
>   |
>   = note: unions with `Copy` and `ManuallyDrop` fields are stable; there is no intent to stabilize more
>error[E0740]: unions cannot contain fields that may need dropping
>  --> $DIR/union.rs:LL:CC
>   |
>LL |         s: S,
>LL |         s: S,
>   |         ^^^^
>   |
>   = note: a type is guaranteed not to need dropping when it implements `Copy`, or when it is the special `ManuallyDrop<_>` type
>help: when the type does not implement `Copy`, wrap it inside a `ManuallyDrop<_>` and ensure it is manually dropped
>   |
>LL |         s: std::mem::ManuallyDrop<S>,
>   |            +++++++++++++++++++++++ +
>error: aborting due to 2 previous errors
>
>Some errors have detailed explanations: E0557, E0740.
>For more information about an error, try `rustc --explain E0557`.
---

---- compile_test stdout ----
diff of stderr:

-error: you are implementing `Clone` explicitly on a `Copy` type
+error[E0557]: feature has been removed
+  --> $DIR/derive.rs:1:12
    |
    |
-LL | / impl Clone for Qux {
-LL | |     fn clone(&self) -> Self {
-LL | |         Qux
-LL | |     }
-LL | | }
-   | |_^
+LL | #![feature(untagged_unions)]
    |
    |
-   = note: `-D clippy::expl-impl-clone-on-copy` implied by `-D warnings`
-note: consider deriving `Clone` or removing `Copy`
-   |
-   |
-LL | / impl Clone for Qux {
-LL | |     fn clone(&self) -> Self {
-LL | |         Qux
-LL | |     }
-LL | | }
-   | |_^
+   = note: unions with `Copy` and `ManuallyDrop` fields are stable; there is no intent to stabilize more
 
-error: you are implementing `Clone` explicitly on a `Copy` type
-   |
-   |
-LL | / impl<'a> Clone for Lt<'a> {
-LL | |     fn clone(&self) -> Self {
-LL | |         unimplemented!()
-LL | |     }
-LL | | }
-   | |_^
-   |
-note: consider deriving `Clone` or removing `Copy`
-   |
-   |
-LL | / impl<'a> Clone for Lt<'a> {
-LL | |     fn clone(&self) -> Self {
-LL | |         unimplemented!()
-LL | |     }
-LL | | }
-   | |_^
 
 
-error: you are implementing `Clone` explicitly on a `Copy` type
-   |
-   |
-LL | / impl Clone for BigArray {
-LL | |     fn clone(&self) -> Self {
-LL | |         unimplemented!()
-LL | |     }
-LL | | }
-   | |_^
-   |
-note: consider deriving `Clone` or removing `Copy`
-   |
-   |
-LL | / impl Clone for BigArray {
-LL | |     fn clone(&self) -> Self {
-LL | |         unimplemented!()
-LL | |     }
-LL | | }
-   | |_^
-
-error: you are implementing `Clone` explicitly on a `Copy` type
-   |
-   |
-LL | / impl Clone for FnPtr {
-LL | |     fn clone(&self) -> Self {
-LL | |         unimplemented!()
-LL | |     }
-LL | | }
-   | |_^
-   |
-note: consider deriving `Clone` or removing `Copy`
-   |
-   |
-LL | / impl Clone for FnPtr {
-LL | |     fn clone(&self) -> Self {
-LL | |         unimplemented!()
-LL | |     }
-LL | | }
-   | |_^
-
-error: you are implementing `Clone` explicitly on a `Copy` type
-   |
-   |
-LL | / impl<T: Clone> Clone for Generic2<T> {
-LL | |     fn clone(&self) -> Self {
-LL | |         Self(self.0.clone())
-LL | |     }
-LL | | }
-   | |_^
-   |
-note: consider deriving `Clone` or removing `Copy`
-   |
-   |
-LL | / impl<T: Clone> Clone for Generic2<T> {
-LL | |     fn clone(&self) -> Self {
-LL | |         Self(self.0.clone())
-LL | |     }
-LL | | }
-   | |_^
-error: aborting due to 5 previous errors
-
+For more information about this error, try `rustc --explain E0557`.
 
---
To only update this specific test, also pass `--test-args derive.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/clippy-driver" "tests/ui/derive.rs" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/test/ui" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/test/ui/derive.stage-id" "-A" "unused" "--emit=metadata" "-Dwarnings" "-Zui-testing" "-L" "dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps" "-L" "dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps" "--extern" "rustc_semver=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/librustc_semver-963bbd3f89834643.rlib" "--extern" "if_chain=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libif_chain-03f75cdc6d4d3afc.rlib" "--extern" "quote=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libquote-021aec868151835c.rlib" "--extern" "serde=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libserde-46430df947b7dad0.rlib" "--extern" "syn=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libsyn-0c795f7a8756f15a.rlib" "--extern" "itertools=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libitertools-cdd893c121eb00e4.rlib" "--extern" "regex=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libregex-7d13fa063f867ef0.rlib" "--extern" "clippy_utils=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libclippy_utils-b92911696ae4394a.rlib" "--extern" "tokio=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libtokio-dcc59fbd39a40970.rlib" "--extern" "parking_lot=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libparking_lot-aceff80e643e9fe7.rlib" "--extern" "serde_derive=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps/libserde_derive-5411643be5ff72c2.so" "--extern" "clippy_lints=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libclippy_lints-ff530e80824c3a36.rlib" "--extern" "derive_new=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps/libderive_new-71205fa4273edf27.so" "--extern" "futures=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libfutures-61ecef333190a996.rlib" "--edition=2021" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/test/ui/derive.stage-id.aux"
------------------------------------------

------------------------------------------
stderr:
stderr:
------------------------------------------
{"message":"feature has been removed","code":{"code":"E0557","explanation":"A feature attribute named a feature that has been removed.\n\nErroneous code example:\n\n```compile_fail,E0557\n#![feature(managed_boxes)] // error: feature has been removed\n```\n\nDelete the offending feature attribute.\n"},"level":"error","spans":[{"file_name":"tests/ui/derive.rs","byte_start":11,"byte_end":26,"line_start":1,"line_end":1,"column_start":12,"column_end":27,"is_primary":true,"text":[{"text":"#![feature(untagged_unions)]","highlight_start":12,"highlight_end":27}],"label":"feature has been removed","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"unions with `Copy` and `ManuallyDrop` fields are stable; there is no intent to stabilize more","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error[E0557]: feature has been removed\n  --> tests/ui/derive.rs:1:12\n   |\nLL | #![feature(untagged_unions)]\n   |            ^^^^^^^^^^^^^^^ feature has been removed\n   |\n   = note: unions with `Copy` and `ManuallyDrop` fields are stable; there is no intent to stabilize more\n\n"}
{"message":"For more information about this error, try `rustc --explain E0557`.","code":null,"level":"failure-note","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0557`.\n"}

------------------------------------------

---
-   |     ^^
+LL | #![feature(untagged_unions)]
+   |            ^^^^^^^^^^^^^^^ feature has been removed
    |
-   = note: `-D clippy::no-effect` implied by `-D warnings`
+   = note: unions with `Copy` and `ManuallyDrop` fields are stable; there is no intent to stabilize more
-error: statement with no effect
-  --> $DIR/no_effect.rs:96:5
-   |
-LL |     s2;
---
-   |     ^^^^^^^^^
-
-error: statement with no effect
-  --> $DIR/no_effect.rs:99:5
-   |
-LL |     Struct { field: 0 };
-   |     ^^^^^^^^^^^^^^^^^^^^
-error: statement with no effect
-  --> $DIR/no_effect.rs:100:5
-   |
-   |
-LL |     Struct { ..s };
-   |     ^^^^^^^^^^^^^^^
-error: statement with no effect
-  --> $DIR/no_effect.rs:101:5
-   |
-   |
-LL |     Union { a: 0 };
-   |     ^^^^^^^^^^^^^^^
-error: statement with no effect
-  --> $DIR/no_effect.rs:102:5
-   |
-LL |     Enum::Tuple(0);
-LL |     Enum::Tuple(0);
-   |     ^^^^^^^^^^^^^^^
-
-error: statement with no effect
-  --> $DIR/no_effect.rs:103:5
-   |
-LL |     Enum::Struct { field: 0 };
-   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
-error: statement with no effect
-  --> $DIR/no_effect.rs:104:5
-   |
-LL |     5 + 6;
---
-   |     ^^^^^^^^^
-
-error: statement with no effect
-  --> $DIR/no_effect.rs:115:5
-   |
-LL |     [42, 55][1];
-   |     ^^^^^^^^^^^^
-error: statement with no effect
-  --> $DIR/no_effect.rs:116:5
-   |
-   |
-LL |     (42, 55).1;
-   |     ^^^^^^^^^^^
-error: statement with no effect
-  --> $DIR/no_effect.rs:117:5
-   |
-   |
-LL |     [42; 55];
-   |     ^^^^^^^^^
-error: statement with no effect
-  --> $DIR/no_effect.rs:118:5
-   |
-   |
-LL |     [42; 55][13];
-   |     ^^^^^^^^^^^^^
-error: statement with no effect
-  --> $DIR/no_effect.rs:120:5
-   |
-   |
-LL |     || x += 5;
-   |     ^^^^^^^^^^
-error: statement with no effect
-  --> $DIR/no_effect.rs:122:5
-   |
-   |
-LL |     FooString { s: s };
-   |     ^^^^^^^^^^^^^^^^^^^
-
-error: binding to `_` prefixed variable with no side-effect
-   |
-   |
-LL |     let _unused = 1;
-   |     ^^^^^^^^^^^^^^^^
-   |
-   = note: `-D clippy::no-effect-underscore-binding` implied by `-D warnings`
-
-error: binding to `_` prefixed variable with no side-effect
-   |
-   |
-LL |     let _penguin = || println!("Some helpful closure");
-   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-
-error: binding to `_` prefixed variable with no side-effect
-   |
-   |
-LL |     let _duck = Struct { field: 0 };
-   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-
-error: binding to `_` prefixed variable with no side-effect
-   |
-   |
-LL |     let _cat = [2, 4, 6, 8][2];
-   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
-error: aborting due to 30 previous errors
-
+For more information about this error, try `rustc --explain E0557`.
 
---
To only update this specific test, also pass `--test-args no_effect.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/clippy-driver" "tests/ui/no_effect.rs" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/test/ui" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/test/ui/no_effect.stage-id" "-A" "unused" "--emit=metadata" "-Dwarnings" "-Zui-testing" "-L" "dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps" "-L" "dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps" "--extern" "rustc_semver=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/librustc_semver-963bbd3f89834643.rlib" "--extern" "if_chain=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libif_chain-03f75cdc6d4d3afc.rlib" "--extern" "quote=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libquote-021aec868151835c.rlib" "--extern" "serde=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libserde-46430df947b7dad0.rlib" "--extern" "syn=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libsyn-0c795f7a8756f15a.rlib" "--extern" "itertools=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libitertools-cdd893c121eb00e4.rlib" "--extern" "regex=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libregex-7d13fa063f867ef0.rlib" "--extern" "clippy_utils=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libclippy_utils-b92911696ae4394a.rlib" "--extern" "tokio=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libtokio-dcc59fbd39a40970.rlib" "--extern" "parking_lot=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libparking_lot-aceff80e643e9fe7.rlib" "--extern" "serde_derive=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps/libserde_derive-5411643be5ff72c2.so" "--extern" "clippy_lints=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libclippy_lints-ff530e80824c3a36.rlib" "--extern" "derive_new=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps/libderive_new-71205fa4273edf27.so" "--extern" "futures=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libfutures-61ecef333190a996.rlib" "--edition=2021" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/test/ui/no_effect.stage-id.aux"
------------------------------------------

------------------------------------------
stderr:
stderr:
------------------------------------------
{"message":"feature has been removed","code":{"code":"E0557","explanation":"A feature attribute named a feature that has been removed.\n\nErroneous code example:\n\n```compile_fail,E0557\n#![feature(managed_boxes)] // error: feature has been removed\n```\n\nDelete the offending feature attribute.\n"},"level":"error","spans":[{"file_name":"tests/ui/no_effect.rs","byte_start":232,"byte_end":247,"line_start":7,"line_end":7,"column_start":12,"column_end":27,"is_primary":true,"text":[{"text":"#![feature(untagged_unions)]","highlight_start":12,"highlight_end":27}],"label":"feature has been removed","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"unions with `Copy` and `ManuallyDrop` fields are stable; there is no intent to stabilize more","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error[E0557]: feature has been removed\n  --> tests/ui/no_effect.rs:7:12\n   |\nLL | #![feature(untagged_unions)]\n   |            ^^^^^^^^^^^^^^^ feature has been removed\n   |\n   = note: unions with `Copy` and `ManuallyDrop` fields are stable; there is no intent to stabilize more\n\n"}
{"message":"For more information about this error, try `rustc --explain E0557`.","code":null,"level":"failure-note","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0557`.\n"}

------------------------------------------

@bors
Copy link
Contributor

bors commented Jul 12, 2022

💔 Test failed - checks-actions

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
>   |
>LL | #![feature(untagged_unions)]
>   |            ^^^^^^^^^^^^^^^ feature has been removed
>   |
>   = note: unions with `Copy` and `ManuallyDrop` fields are stable; there is no intent to stabilize more
>error: aborting due to previous error
>
>For more information about this error, try `rustc --explain E0557`.
>
---
>   |
>LL | #![feature(untagged_unions)]
>   |            ^^^^^^^^^^^^^^^ feature has been removed
>   |
>   = note: unions with `Copy` and `ManuallyDrop` fields are stable; there is no intent to stabilize more
>error[E0740]: unions cannot contain fields that may need dropping
>  --> $DIR/union.rs:LL:CC
>   |
>LL |         s: S,
>LL |         s: S,
>   |         ^^^^
>   |
>   = note: a type is guaranteed not to need dropping when it implements `Copy`, or when it is the special `ManuallyDrop<_>` type
>help: when the type does not implement `Copy`, wrap it inside a `ManuallyDrop<_>` and ensure it is manually dropped
>   |
>LL |         s: std::mem::ManuallyDrop<S>,
>   |            +++++++++++++++++++++++ +
>error: aborting due to 2 previous errors
>
>Some errors have detailed explanations: E0557, E0740.
>For more information about an error, try `rustc --explain E0557`.
---

---- compile_test stdout ----
diff of stderr:

-error: you are implementing `Clone` explicitly on a `Copy` type
+error[E0557]: feature has been removed
+  --> $DIR/derive.rs:1:12
    |
    |
-LL | / impl Clone for Qux {
-LL | |     fn clone(&self) -> Self {
-LL | |         Qux
-LL | |     }
-LL | | }
-   | |_^
+LL | #![feature(untagged_unions)]
    |
    |
-   = note: `-D clippy::expl-impl-clone-on-copy` implied by `-D warnings`
-note: consider deriving `Clone` or removing `Copy`
-   |
-   |
-LL | / impl Clone for Qux {
-LL | |     fn clone(&self) -> Self {
-LL | |         Qux
-LL | |     }
-LL | | }
-   | |_^
+   = note: unions with `Copy` and `ManuallyDrop` fields are stable; there is no intent to stabilize more
 
-error: you are implementing `Clone` explicitly on a `Copy` type
-   |
-   |
-LL | / impl<'a> Clone for Lt<'a> {
-LL | |     fn clone(&self) -> Self {
-LL | |         unimplemented!()
-LL | |     }
-LL | | }
-   | |_^
-   |
-note: consider deriving `Clone` or removing `Copy`
-   |
-   |
-LL | / impl<'a> Clone for Lt<'a> {
-LL | |     fn clone(&self) -> Self {
-LL | |         unimplemented!()
-LL | |     }
-LL | | }
-   | |_^
 
 
-error: you are implementing `Clone` explicitly on a `Copy` type
-   |
-   |
-LL | / impl Clone for BigArray {
-LL | |     fn clone(&self) -> Self {
-LL | |         unimplemented!()
-LL | |     }
-LL | | }
-   | |_^
-   |
-note: consider deriving `Clone` or removing `Copy`
-   |
-   |
-LL | / impl Clone for BigArray {
-LL | |     fn clone(&self) -> Self {
-LL | |         unimplemented!()
-LL | |     }
-LL | | }
-   | |_^
-
-error: you are implementing `Clone` explicitly on a `Copy` type
-   |
-   |
-LL | / impl Clone for FnPtr {
-LL | |     fn clone(&self) -> Self {
-LL | |         unimplemented!()
-LL | |     }
-LL | | }
-   | |_^
-   |
-note: consider deriving `Clone` or removing `Copy`
-   |
-   |
-LL | / impl Clone for FnPtr {
-LL | |     fn clone(&self) -> Self {
-LL | |         unimplemented!()
-LL | |     }
-LL | | }
-   | |_^
-
-error: you are implementing `Clone` explicitly on a `Copy` type
-   |
-   |
-LL | / impl<T: Clone> Clone for Generic2<T> {
-LL | |     fn clone(&self) -> Self {
-LL | |         Self(self.0.clone())
-LL | |     }
-LL | | }
-   | |_^
-   |
-note: consider deriving `Clone` or removing `Copy`
-   |
-   |
-LL | / impl<T: Clone> Clone for Generic2<T> {
-LL | |     fn clone(&self) -> Self {
-LL | |         Self(self.0.clone())
-LL | |     }
-LL | | }
-   | |_^
-error: aborting due to 5 previous errors
-
+For more information about this error, try `rustc --explain E0557`.
 
---
To only update this specific test, also pass `--test-args derive.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/clippy-driver" "tests/ui/derive.rs" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/test/ui" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/test/ui/derive.stage-id" "-A" "unused" "--emit=metadata" "-Dwarnings" "-Zui-testing" "-L" "dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps" "-L" "dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps" "--extern" "syn=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libsyn-0c795f7a8756f15a.rlib" "--extern" "quote=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libquote-021aec868151835c.rlib" "--extern" "futures=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libfutures-61ecef333190a996.rlib" "--extern" "clippy_lints=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libclippy_lints-ff530e80824c3a36.rlib" "--extern" "itertools=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libitertools-cdd893c121eb00e4.rlib" "--extern" "clippy_utils=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libclippy_utils-b92911696ae4394a.rlib" "--extern" "serde_derive=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps/libserde_derive-5411643be5ff72c2.so" "--extern" "rustc_semver=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/librustc_semver-963bbd3f89834643.rlib" "--extern" "parking_lot=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libparking_lot-aceff80e643e9fe7.rlib" "--extern" "if_chain=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libif_chain-03f75cdc6d4d3afc.rlib" "--extern" "derive_new=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps/libderive_new-71205fa4273edf27.so" "--extern" "tokio=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libtokio-dcc59fbd39a40970.rlib" "--extern" "regex=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libregex-7d13fa063f867ef0.rlib" "--extern" "serde=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libserde-46430df947b7dad0.rlib" "--edition=2021" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/test/ui/derive.stage-id.aux"
------------------------------------------

------------------------------------------
stderr:
stderr:
------------------------------------------
{"message":"feature has been removed","code":{"code":"E0557","explanation":"A feature attribute named a feature that has been removed.\n\nErroneous code example:\n\n```compile_fail,E0557\n#![feature(managed_boxes)] // error: feature has been removed\n```\n\nDelete the offending feature attribute.\n"},"level":"error","spans":[{"file_name":"tests/ui/derive.rs","byte_start":11,"byte_end":26,"line_start":1,"line_end":1,"column_start":12,"column_end":27,"is_primary":true,"text":[{"text":"#![feature(untagged_unions)]","highlight_start":12,"highlight_end":27}],"label":"feature has been removed","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"unions with `Copy` and `ManuallyDrop` fields are stable; there is no intent to stabilize more","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error[E0557]: feature has been removed\n  --> tests/ui/derive.rs:1:12\n   |\nLL | #![feature(untagged_unions)]\n   |            ^^^^^^^^^^^^^^^ feature has been removed\n   |\n   = note: unions with `Copy` and `ManuallyDrop` fields are stable; there is no intent to stabilize more\n\n"}
{"message":"For more information about this error, try `rustc --explain E0557`.","code":null,"level":"failure-note","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0557`.\n"}

------------------------------------------

---
-   |     ^^
+LL | #![feature(untagged_unions)]
+   |            ^^^^^^^^^^^^^^^ feature has been removed
    |
-   = note: `-D clippy::no-effect` implied by `-D warnings`
+   = note: unions with `Copy` and `ManuallyDrop` fields are stable; there is no intent to stabilize more
-error: statement with no effect
-  --> $DIR/no_effect.rs:96:5
-   |
-LL |     s2;
---
-   |     ^^^^^^^^^
-
-error: statement with no effect
-  --> $DIR/no_effect.rs:99:5
-   |
-LL |     Struct { field: 0 };
-   |     ^^^^^^^^^^^^^^^^^^^^
-error: statement with no effect
-  --> $DIR/no_effect.rs:100:5
-   |
-   |
-LL |     Struct { ..s };
-   |     ^^^^^^^^^^^^^^^
-error: statement with no effect
-  --> $DIR/no_effect.rs:101:5
-   |
-   |
-LL |     Union { a: 0 };
-   |     ^^^^^^^^^^^^^^^
-error: statement with no effect
-  --> $DIR/no_effect.rs:102:5
-   |
-LL |     Enum::Tuple(0);
-LL |     Enum::Tuple(0);
-   |     ^^^^^^^^^^^^^^^
-
-error: statement with no effect
-  --> $DIR/no_effect.rs:103:5
-   |
-LL |     Enum::Struct { field: 0 };
-   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
-error: statement with no effect
-  --> $DIR/no_effect.rs:104:5
-   |
-LL |     5 + 6;
---
-   |     ^^^^^^^^^
-
-error: statement with no effect
-  --> $DIR/no_effect.rs:115:5
-   |
-LL |     [42, 55][1];
-   |     ^^^^^^^^^^^^
-error: statement with no effect
-  --> $DIR/no_effect.rs:116:5
-   |
-   |
-LL |     (42, 55).1;
-   |     ^^^^^^^^^^^
-error: statement with no effect
-  --> $DIR/no_effect.rs:117:5
-   |
-   |
-LL |     [42; 55];
-   |     ^^^^^^^^^
-error: statement with no effect
-  --> $DIR/no_effect.rs:118:5
-   |
-   |
-LL |     [42; 55][13];
-   |     ^^^^^^^^^^^^^
-error: statement with no effect
-  --> $DIR/no_effect.rs:120:5
-   |
-   |
-LL |     || x += 5;
-   |     ^^^^^^^^^^
-error: statement with no effect
-  --> $DIR/no_effect.rs:122:5
-   |
-   |
-LL |     FooString { s: s };
-   |     ^^^^^^^^^^^^^^^^^^^
-
-error: binding to `_` prefixed variable with no side-effect
-   |
-   |
-LL |     let _unused = 1;
-   |     ^^^^^^^^^^^^^^^^
-   |
-   = note: `-D clippy::no-effect-underscore-binding` implied by `-D warnings`
-
-error: binding to `_` prefixed variable with no side-effect
-   |
-   |
-LL |     let _penguin = || println!("Some helpful closure");
-   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-
-error: binding to `_` prefixed variable with no side-effect
-   |
-   |
-LL |     let _duck = Struct { field: 0 };
-   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-
-error: binding to `_` prefixed variable with no side-effect
-   |
-   |
-LL |     let _cat = [2, 4, 6, 8][2];
-   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
-error: aborting due to 30 previous errors
-
+For more information about this error, try `rustc --explain E0557`.
 
---
To only update this specific test, also pass `--test-args no_effect.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/clippy-driver" "tests/ui/no_effect.rs" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/test/ui" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/test/ui/no_effect.stage-id" "-A" "unused" "--emit=metadata" "-Dwarnings" "-Zui-testing" "-L" "dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps" "-L" "dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps" "--extern" "syn=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libsyn-0c795f7a8756f15a.rlib" "--extern" "quote=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libquote-021aec868151835c.rlib" "--extern" "futures=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libfutures-61ecef333190a996.rlib" "--extern" "clippy_lints=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libclippy_lints-ff530e80824c3a36.rlib" "--extern" "itertools=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libitertools-cdd893c121eb00e4.rlib" "--extern" "clippy_utils=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libclippy_utils-b92911696ae4394a.rlib" "--extern" "serde_derive=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps/libserde_derive-5411643be5ff72c2.so" "--extern" "rustc_semver=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/librustc_semver-963bbd3f89834643.rlib" "--extern" "parking_lot=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libparking_lot-aceff80e643e9fe7.rlib" "--extern" "if_chain=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libif_chain-03f75cdc6d4d3afc.rlib" "--extern" "derive_new=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps/libderive_new-71205fa4273edf27.so" "--extern" "tokio=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libtokio-dcc59fbd39a40970.rlib" "--extern" "regex=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libregex-7d13fa063f867ef0.rlib" "--extern" "serde=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libserde-46430df947b7dad0.rlib" "--edition=2021" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/test/ui/no_effect.stage-id.aux"
------------------------------------------

------------------------------------------
stderr:
stderr:
------------------------------------------
{"message":"feature has been removed","code":{"code":"E0557","explanation":"A feature attribute named a feature that has been removed.\n\nErroneous code example:\n\n```compile_fail,E0557\n#![feature(managed_boxes)] // error: feature has been removed\n```\n\nDelete the offending feature attribute.\n"},"level":"error","spans":[{"file_name":"tests/ui/no_effect.rs","byte_start":232,"byte_end":247,"line_start":7,"line_end":7,"column_start":12,"column_end":27,"is_primary":true,"text":[{"text":"#![feature(untagged_unions)]","highlight_start":12,"highlight_end":27}],"label":"feature has been removed","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"unions with `Copy` and `ManuallyDrop` fields are stable; there is no intent to stabilize more","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error[E0557]: feature has been removed\n  --> tests/ui/no_effect.rs:7:12\n   |\nLL | #![feature(untagged_unions)]\n   |            ^^^^^^^^^^^^^^^ feature has been removed\n   |\n   = note: unions with `Copy` and `ManuallyDrop` fields are stable; there is no intent to stabilize more\n\n"}
{"message":"For more information about this error, try `rustc --explain E0557`.","code":null,"level":"failure-note","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0557`.\n"}

------------------------------------------

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants