Code

Rollup of 8 pull requests#69746

Code

Merged

bors merged 27 commits intorust-lang:masterrust-lang/rust:masterfrom Dylan-DPC-zz:rollup-wr6dvdkDylan-DPC-zz/rust:rollup-wr6dvdkCopy head branch name to clipboardMar 6, 2020

+128-129

Commits

Commits on Mar 4, 2020

• Add explanation for E0380

  GuillaumeGomez

  committed
  c745b4a

  Copy full SHA for c745b4a

• use integer assoc consts instead of methods

  RalfJung

  committed
  6db7e34

  Copy full SHA for 6db7e34

• cover some more nearby cases

  RalfJung

  committed
  f0c3cf2

  Copy full SHA for f0c3cf2

• Update macros.rs: fix documentation typo.

  fables-tales

  authored
  729d49d

  Copy full SHA for 729d49d

• Don't use .ok() before unwrapping via .expect() on a Result.

  Show description for 07168f9
  matthiaskrgr

  committed
  07168f9

  Copy full SHA for 07168f9

• Use .map() to modify data inside Options instead of using .and_then(|x| Some(y)) (clippy::option_and_then_some)

  matthiaskrgr

  committed
  569676b

  Copy full SHA for 569676b

• Use .as_deref() instead of .as_ref().map(Deref::deref) (clippy::option_as_ref_deref)

  matthiaskrgr

  committed
  38f5db7

  Copy full SHA for 38f5db7

• Don't use "if let" bindings to only check a value and not actually bind anything.

  Show description for d8d2004
  matthiaskrgr

  committed
  d8d2004

  Copy full SHA for d8d2004

• Use single-char patter on {ends,starts}_with and remove clone on copy type.

  Show description for 80ed505
  matthiaskrgr

  committed
  80ed505

  Copy full SHA for 80ed505

Commits on Mar 5, 2020

• Make link to std::str active

  LeSeulArtichaut

  authored
  6ed4829

  Copy full SHA for 6ed4829

• Clean E0382 and E0384 explanations

  GuillaumeGomez

  committed
  6b28a8c

  Copy full SHA for 6b28a8c

• Remove redundant patterns when matching ( x @ _ to x) (clippy::redundant_pattern)

  matthiaskrgr

  committed
  edd3e17

  Copy full SHA for edd3e17

• Const items have by default a static lifetime, there's no need to annotate it. (clippy::redundant_static_lifetimes)

  matthiaskrgr

  committed
  c2bbe33

  Copy full SHA for c2bbe33

• Use simple 'for i in x' loops instead of 'while let Some(x) = x.next()' loops on iterators. (clippy::while_let_on_iterator)

  matthiaskrgr

  committed
  3e70c8e

  Copy full SHA for 3e70c8e

• Use righthand '&' instead of lefthand "ref". (clippy::toplevel_ref_arg)

  matthiaskrgr

  committed
  3fc5c11

  Copy full SHA for 3fc5c11

• Don't always eval arguments inside .expect(), use unwrap_or_else and closure. (clippy::expect_fun_call)

  matthiaskrgr

  committed
  a1c3eb6

  Copy full SHA for a1c3eb6

• Use more efficient &&str to String conversion (clippy::inefficient_to_string)

  matthiaskrgr

  committed
  8ba92d9

  Copy full SHA for 8ba92d9

• Don't pass &mut where immutable reference (&) is sufficient (clippy::unnecessary_mut_passed)

  matthiaskrgr

  committed
  84577c8

  Copy full SHA for 84577c8

• Fixed a typo

  Show description for 79bc934
  TrolledWoods

  authored
  79bc934

  Copy full SHA for 79bc934

• Rollup merge of rust-lang#69697 - GuillaumeGomez:explanation-e0380, r=Dylan-DPC

  Show description for e01dc83
  Dylan-DPC

  authored
  e01dc83

  Copy full SHA for e01dc83

• Rollup merge of rust-lang#69698 - RalfJung:int_assoc, r=davidtwco

  Show description for 44f184a
  Dylan-DPC

  authored
  44f184a

  Copy full SHA for 44f184a

• Rollup merge of rust-lang#69711 - penelopezone:patch-1, r=steveklabnik

  Show description for 1896266
  Dylan-DPC

  authored
  1896266

  Copy full SHA for 1896266

• Rollup merge of rust-lang#69713 - matthiaskrgr:more_cleanup, r=cramertj

  Show description for 22a743b
  Dylan-DPC

  authored
  22a743b

  Copy full SHA for 22a743b

• Rollup merge of rust-lang#69728 - LeSeulArtichaut:patch-1, r=steveklabnik

  Show description for 7aac135
  Dylan-DPC

  authored
  7aac135

  Copy full SHA for 7aac135

• Rollup merge of rust-lang#69732 - GuillaumeGomez:cleanup-e0382-e0384, r=Dylan-DPC

  Show description for 558115b
  Dylan-DPC

  authored
  558115b

  Copy full SHA for 558115b

• Rollup merge of rust-lang#69736 - matthiaskrgr:even_more_clippy, r=Dylan-DPC

  Show description for 67d735c
  Dylan-DPC

  authored
  67d735c

  Copy full SHA for 67d735c

• Rollup merge of rust-lang#69742 - TrolledWoods:patch-1, r=jonas-schievink

  Show description for 80c8434
  Dylan-DPC

  authored
  80c8434

  Copy full SHA for 80c8434