-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 10 pull requests #67660
Rollup of 10 pull requests #67660
Conversation
The callbacks have precisely two states: the default, and the one present throughout almost all of the rustc run (the filled in value which has access to TyCtxt). We used to store this as a thread local, and reset it on each thread to the non-default value. But this is somewhat wasteful, since there is no reason to set it globally -- while the callbacks themselves access TLS, they do not do so in a manner that fails in when we do not have TLS to work with.
reuse `capacity` variable in slice::repeat None
…-intrinsics, r=Centril Use issue = "none" instead of "0" in intrinsics `issue = "0"` was incorrectly used in rust-lang@9ee16e1, the project is moving away from issue 0
tidy: change msdn links to newer locations see accouncement at https://docs.microsoft.com/welcome-to-docs The script that I used: https://gist.github.com/lzutao/1449c9210ad91899841d62e0058d2caa
…=Zoxc Set callbacks globally This sets the callbacks from syntax and rustc_errors just once, utilizing static (rather than thread-local) storage.
…docs, r=Dylan-DPC Remove `compiler_builtins_lib` documentation Fixes rust-lang#67593
…r=steveklabnik Remove redundant link texts Most of these links are followed by a parenthesized expression. I think that the redundant link texts were added to prevent interpretation as an inline link. This is unnecessary since the closing square bracket and opening parenthesis are separated by whitespace.
…sleywiser Work around a resolve bug in const prop r? @wesleywiser @anp This isn't exposed right now, but further changes to rustc may start causing bugs without this.
…nks, r=steveklabnik Convert collapsed to shortcut reference links
…ulacrum Update .mailmap
…dtolnay Document safety of Path casting I would personally feel more comfortable making the relevant (internal anyway) types repr(transparent) and then documenting that we can make these casts because of that, but I believe this is a more minimal PR, so posting it first. Resolves rust-lang#45910.
@bors r+ p=10 rollup=never |
📌 Commit ba8fa67 has been approved by |
⌛ Testing commit ba8fa67 with merge 9bb7f898fd39b5966ba6e1d99eebedcb0be3d163... |
Testing highfive, ignore this. |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
💔 Test failed - checks-azure |
Successful merges:
capacity
variable in slice::repeat #67576 (reusecapacity
variable in slice::repeat)compiler_builtins_lib
documentation #67617 (Removecompiler_builtins_lib
documentation)Failed merges:
r? @ghost